netdev - Re: [PATCH v2 net-next 13/14] rtnetlink: Return int from rtnl_af

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241022194201.70485-1-kuniyu@amazon.com>
Date: Tue, 22 Oct 2024 12:42:01 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <horms@...nel.org>
CC: <davem@...emloft.net>, <dsahern@...nel.org>, <edumazet@...gle.com>,
	<jk@...econstruct.com.au>, <kuba@...nel.org>, <kuni1840@...il.com>,
	<kuniyu@...zon.com>, <matt@...econstruct.com.au>, <netdev@...r.kernel.org>,
	<pabeni@...hat.com>, <razor@...ckwall.org>, <roopa@...dia.com>
Subject: Re: [PATCH v2 net-next 13/14] rtnetlink: Return int from rtnl_af_register().

From: Simon Horman <horms@...nel.org>
Date: Tue, 22 Oct 2024 09:59:20 +0100
> On Tue, Oct 22, 2024 at 10:53:32AM +0200, Paolo Abeni wrote:
> > On 10/16/24 20:53, Kuniyuki Iwashima wrote:
> > > diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
> > > index 445e6ffed75e..70b663aca209 100644
> > > --- a/net/core/rtnetlink.c
> > > +++ b/net/core/rtnetlink.c
> > > @@ -686,11 +686,13 @@ static const struct rtnl_af_ops *rtnl_af_lookup(const int family)
> > >   *
> > >   * Returns 0 on success or a negative error code.
> > >   */
> > > -void rtnl_af_register(struct rtnl_af_ops *ops)
> > > +int rtnl_af_register(struct rtnl_af_ops *ops)
> > >  {
> > >  	rtnl_lock();
> > >  	list_add_tail_rcu(&ops->list, &rtnl_af_ops);
> > >  	rtnl_unlock();
> > > +
> > > +	return 0;
> > >  }
> > >  EXPORT_SYMBOL_GPL(rtnl_af_register);
> > 
> > kdoc complains about the missing description for the return value. You
> > need to replace 'Returns' with '@...urn'.
> > 
> > Not blocking, but please follow-up.
> 
> FWIIW, I think "Return: " or "Returns: " also works.

Sure, will post a followup shortly.

Thanks!