netdev - Re: [PATCH net] net: netfilter: Fix use-after-free in get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <8ca3f6271b0a4956b699e1444f7a06ad@huawei.com>
Date: Wed, 23 Oct 2024 01:28:44 +0000
From: "dongchenchen (A)" <dongchenchen2@...wei.com>
To: Florian Westphal <fw@...len.de>
CC: "pablo@...filter.org" <pablo@...filter.org>, "kadlec@...filter.org"
	<kadlec@...filter.org>, "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"kuniyu@...zon.com" <kuniyu@...zon.com>, "netfilter-devel@...r.kernel.org"
	<netfilter-devel@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, yuehaibing <yuehaibing@...wei.com>
Subject: Re: [PATCH net] net: netfilter: Fix use-after-free in get_info()

> Dong Chenchen <dongchenchen2@...wei.com> wrote:
> >  net/netfilter/x_tables.c | 8 +++++---
> >  1 file changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/net/netfilter/x_tables.c b/net/netfilter/x_tables.c index
> > da5d929c7c85..359c880ecb07 100644
> > --- a/net/netfilter/x_tables.c
> > +++ b/net/netfilter/x_tables.c
> > @@ -1239,6 +1239,7 @@ struct xt_table *xt_find_table_lock(struct net *net,
> u_int8_t af,
> >  	struct module *owner = NULL;
> >  	struct xt_template *tmpl;
> >  	struct xt_table *t;
> > +	int err = -ENOENT;
> >
> >  	mutex_lock(&xt[af].mutex);
> >  	list_for_each_entry(t, &xt_net->tables[af], list) @@ -1247,8 +1248,6
> > @@ struct xt_table *xt_find_table_lock(struct net *net, u_int8_t af,
> >
> >  	/* Table doesn't exist in this netns, check larval list */
> >  	list_for_each_entry(tmpl, &xt_templates[af], list) {
> > -		int err;
> > -
> >  		if (strcmp(tmpl->name, name))
> >  			continue;
> >  		if (!try_module_get(tmpl->me))
> > @@ -1267,6 +1266,9 @@ struct xt_table *xt_find_table_lock(struct net *net,
> u_int8_t af,
> >  		break;
> >  	}
> >
> > +	if (err < 0)
> > +		goto out;
> > +
> >  	/* and once again: */
> >  	list_for_each_entry(t, &xt_net->tables[af], list)
> >  		if (strcmp(t->name, name) == 0)
> 
> Proabably also:
> 
> -  		if (strcmp(t->name, name) == 0)
> +               if (strcmp(t->name, name) == 0 && owner == t->me)
> 
Thank you very much for your suggestions!
V2 will be sent.