netdev - Re: [PATCH v2] netdevsim: Add trailing zero to terminate the string in nsim_nexthop_bucket_activity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sesnhzzz.fsf@nvidia.com>
Date: Wed, 23 Oct 2024 12:29:12 +0200
From: Petr Machata <petrm@...dia.com>
To: Gax-c <zichenxie0106@...il.com>
CC: <kuba@...nel.org>, <andrew+netdev@...n.ch>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <pabeni@...hat.com>, <petrm@...dia.com>,
	<idosch@...dia.com>, <netdev@...r.kernel.org>, <zzjas98@...il.com>,
	<chenyuan0y@...il.com>
Subject: Re: [PATCH v2] netdevsim: Add trailing zero to terminate the string
 in nsim_nexthop_bucket_activity_write()


Gax-c <zichenxie0106@...il.com> writes:

> From: Zichen Xie <zichenxie0106@...il.com>
>
> This was found by a static analyzer.
> We should not forget the trailing zero after copy_from_user()
> if we will further do some string operations, sscanf() in this
> case. Adding a trailing zero will ensure that the function
> performs properly.
>
> Fixes: c6385c0b67c5 ("netdevsim: Allow reporting activity on nexthop buckets")
> Signed-off-by: Zichen Xie <zichenxie0106@...il.com>

Reviewed-by: Petr Machata <petrm@...dia.com>