| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202410230937.zWSJkSuE-lkp@intel.com>
Date: Wed, 23 Oct 2024 09:53:14 +0800
From: kernel test robot <lkp@...el.com>
To: Marek Vasut <marex@...x.de>, linux-wireless@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, Marek Vasut <marex@...x.de>,
Adham Abozaeid <adham.abozaeid@...rochip.com>,
Ajay Singh <ajay.kathat@...rochip.com>,
Alexis Lothoré <alexis.lothore@...tlin.com>,
Claudiu Beznea <claudiu.beznea@...on.dev>,
Conor Dooley <conor+dt@...nel.org>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Kalle Valo <kvalo@...nel.org>,
Krzysztof Kozlowski <krzk@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh@...nel.org>,
devicetree@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] wifi: wilc1000: Rework bus locking
Hi Marek,
kernel test robot noticed the following build errors:
[auto build test ERROR on wireless-next/main]
[also build test ERROR on next-20241022]
[cannot apply to wireless/main linus/master v6.12-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Marek-Vasut/wifi-wilc1000-Rework-bus-locking/20241022-093954
base: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
patch link: https://lore.kernel.org/r/20241022013855.284783-1-marex%40denx.de
patch subject: [PATCH] wifi: wilc1000: Rework bus locking
config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20241023/202410230937.zWSJkSuE-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241023/202410230937.zWSJkSuE-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410230937.zWSJkSuE-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
In file included from include/linux/notifier.h:14,
from include/linux/clk.h:14,
from drivers/net/wireless/microchip/wilc1000/spi.c:7:
drivers/net/wireless/microchip/wilc1000/spi.c: In function 'wilc_spi_claim':
>> drivers/net/wireless/microchip/wilc1000/spi.c:1113:25: error: 'struct wilc' has no member named 'hif_cs'
1113 | mutex_lock(&wilc->hif_cs);
| ^~
include/linux/mutex.h:166:44: note: in definition of macro 'mutex_lock'
166 | #define mutex_lock(lock) mutex_lock_nested(lock, 0)
| ^~~~
drivers/net/wireless/microchip/wilc1000/spi.c: In function 'wilc_spi_release':
drivers/net/wireless/microchip/wilc1000/spi.c:1118:27: error: 'struct wilc' has no member named 'hif_cs'
1118 | mutex_unlock(&wilc->hif_cs);
| ^~
drivers/net/wireless/microchip/wilc1000/spi.c: In function 'wilc_spi_deinit':
drivers/net/wireless/microchip/wilc1000/spi.c:1147:28: error: 'struct wilc' has no member named 'hif_cs'
1147 | mutex_destroy(&wilc->hif_cs);
| ^~
drivers/net/wireless/microchip/wilc1000/spi.c: In function 'wilc_spi_init':
>> drivers/net/wireless/microchip/wilc1000/spi.c:1156:21: error: 'spi' undeclared (first use in this function)
1156 | mutex_init(&spi->hif_cs);
| ^~~
include/linux/mutex.h:64:23: note: in definition of macro 'mutex_init'
64 | __mutex_init((mutex), #mutex, &__key); \
| ^~~~~
drivers/net/wireless/microchip/wilc1000/spi.c:1156:21: note: each undeclared identifier is reported only once for each function it appears in
1156 | mutex_init(&spi->hif_cs);
| ^~~
include/linux/mutex.h:64:23: note: in definition of macro 'mutex_init'
64 | __mutex_init((mutex), #mutex, &__key); \
| ^~~~~
drivers/net/wireless/microchip/wilc1000/spi.c: At top level:
>> drivers/net/wireless/microchip/wilc1000/spi.c:1116:13: warning: 'wilc_spi_release' defined but not used [-Wunused-function]
1116 | static void wilc_spi_release(struct wilc *wilc)
| ^~~~~~~~~~~~~~~~
>> drivers/net/wireless/microchip/wilc1000/spi.c:1111:13: warning: 'wilc_spi_claim' defined but not used [-Wunused-function]
1111 | static void wilc_spi_claim(struct wilc *wilc)
| ^~~~~~~~~~~~~~
vim +1113 drivers/net/wireless/microchip/wilc1000/spi.c
1105
1106 /********************************************
1107 *
1108 * Bus interfaces
1109 *
1110 ********************************************/
> 1111 static void wilc_spi_claim(struct wilc *wilc)
1112 {
> 1113 mutex_lock(&wilc->hif_cs);
1114 }
1115
> 1116 static void wilc_spi_release(struct wilc *wilc)
1117 {
1118 mutex_unlock(&wilc->hif_cs);
1119 }
1120
1121 static int wilc_spi_reset(struct wilc *wilc)
1122 {
1123 struct spi_device *spi = to_spi_device(wilc->dev);
1124 struct wilc_spi *spi_priv = wilc->bus_data;
1125 int result;
1126
1127 result = wilc_spi_special_cmd(wilc, CMD_RESET);
1128 if (result && !spi_priv->probing_crc)
1129 dev_err(&spi->dev, "Failed cmd reset\n");
1130
1131 return result;
1132 }
1133
1134 static bool wilc_spi_is_init(struct wilc *wilc)
1135 {
1136 struct wilc_spi *spi_priv = wilc->bus_data;
1137
1138 return spi_priv->isinit;
1139 }
1140
1141 static int wilc_spi_deinit(struct wilc *wilc)
1142 {
1143 struct wilc_spi *spi_priv = wilc->bus_data;
1144
1145 spi_priv->isinit = false;
1146 wilc_wlan_power(wilc, false);
1147 mutex_destroy(&wilc->hif_cs);
1148 return 0;
1149 }
1150
1151 static int wilc_spi_init(struct wilc *wilc, bool resume)
1152 {
1153 struct wilc_spi *spi_priv = wilc->bus_data;
1154 int ret;
1155
> 1156 mutex_init(&spi->hif_cs);
1157
1158 if (spi_priv->isinit) {
1159 /* Confirm we can read chipid register without error: */
1160 if (wilc_validate_chipid(wilc) == 0)
1161 return 0;
1162 }
1163
1164 wilc_wlan_power(wilc, true);
1165
1166 ret = wilc_spi_configure_bus_protocol(wilc);
1167 if (ret) {
1168 wilc_wlan_power(wilc, false);
1169 return ret;
1170 }
1171
1172 spi_priv->isinit = true;
1173
1174 return 0;
1175 }
1176
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists