netdev - Re: [PATCH net v2] ipv4: ip_tunnel: Fix suspicious RCU usage warning in ip_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLOPZ3DuaZJR6=v=3BFkq8dcy-M3HxXY22y4LS4LhZzhQ@mail.gmail.com>
Date: Wed, 23 Oct 2024 14:33:55 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Ido Schimmel <idosch@...dia.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org, 
	pabeni@...hat.com, dsahern@...nel.org, horms@...nel.org, pshelar@...ira.com
Subject: Re: [PATCH net v2] ipv4: ip_tunnel: Fix suspicious RCU usage warning
 in ip_tunnel_find()

On Wed, Oct 23, 2024 at 2:31 PM Ido Schimmel <idosch@...dia.com> wrote:
>
> The per-netns IP tunnel hash table is protected by the RTNL mutex and
> ip_tunnel_find() is only called from the control path where the mutex is
> taken.
>
> Add a lockdep expression to hlist_for_each_entry_rcu() in
> ip_tunnel_find() in order to validate that the mutex is held and to
> silence the suspicious RCU usage warning [1].
>
> [1]
> WARNING: suspicious RCU usage
> 6.12.0-rc3-custom-gd95d9a31aceb #139 Not tainted
> -----------------------------
> net/ipv4/ip_tunnel.c:221 RCU-list traversed in non-reader section!!
>
> other info that might help us debug this:
>

> Fixes: c54419321455 ("GRE: Refactor GRE tunneling code.")
> Suggested-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks.