netdev - Re: [PATCH net-next v3] selftest/tcp-ao: Add filter tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241023125314.GV402847@kernel.org>
Date: Wed, 23 Oct 2024 13:53:14 +0100
From: Simon Horman <horms@...nel.org>
To: Leo Stone <leocstone@...il.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, shuah@...nel.org, 0x7f454c46@...il.com,
	rdunlap@...radead.org, mnassiri@...na.com,
	jiapeng.chong@...ux.alibaba.com, colin.i.king@...il.com,
	netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3] selftest/tcp-ao: Add filter tests

On Mon, Oct 21, 2024 at 10:46:44AM -0700, Leo Stone wrote:
> Add tests that check if getsockopt(TCP_AO_GET_KEYS) returns the right
> keys when using different filters.
> 
> Sample output:
> 
> > # ok 114 filter keys: by sndid, rcvid, address
> > # ok 115 filter keys: by is_current
> > # ok 116 filter keys: by is_rnext
> > # ok 117 filter keys: by sndid, rcvid
> > # ok 118 filter keys: correct nkeys when in.nkeys < matches
> 
> Acked-by: Dmitry Safonov <0x7f454c46@...il.com>
> Signed-off-by: Leo Stone <leocstone@...il.com>
> ---
> v3:
>   - Ordered locals in reverse xmas tree order
>   - Separated socket fd declaration from assignment
>   - Broke lines longer than 80 columns
> v2: https://lore.kernel.org/netdev/20241016055823.21299-1-leocstone@gmail.com/
>   - Changed 2 unnecessary test_error calls to test_fail
>   - Added another test to make sure getsockopt returns the right nkeys
>   value when the input nkeys is smaller than the number of matching keys
>   - Removed the TODO that this patch addresses
> v1: https://lore.kernel.org/netdev/20241014213313.15100-1-leocstone@gmail.com/
> 
> Thanks to the reviewers for their time and feedback!

Thanks for the updates.

Reviewed-by: Simon Horman <horms@...nel.org>