[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zxj7Xjz36bNTvz9k@hog>
Date: Wed, 23 Oct 2024 16:19:00 +0200
From: Sabrina Dubroca <sd@...asysnail.net>
To: Tariq Toukan <tariqt@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
Saeed Mahameed <saeedm@...dia.com>, Gal Pressman <gal@...dia.com>,
Leon Romanovsky <leonro@...dia.com>,
Jianbo Liu <jianbol@...dia.com>,
Patrisious Haddad <phaddad@...dia.com>, Chris Mi <cmi@...dia.com>
Subject: Re: [PATCH net V2] macsec: Fix use-after-free while sending the
offloading packet
2024-10-21, 13:03:09 +0300, Tariq Toukan wrote:
> From: Jianbo Liu <jianbol@...dia.com>
>
> KASAN reports the following UAF. The metadata_dst, which is used to
> store the SCI value for macsec offload, is already freed by
> metadata_dst_free() in macsec_free_netdev(), while driver still use it
> for sending the packet.
>
> To fix this issue, dst_release() is used instead to release
> metadata_dst. So it is not freed instantly in macsec_free_netdev() if
> still referenced by skb.
Reviewed-by: Sabrina Dubroca <sd@...asysnail.net>
--
Sabrina
Powered by blists - more mailing lists