netdev - Re: [PATCH v1 net-next 1/9] phonet: Pass ifindex to fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJp74yM6D9Wu52CyYKundM0__X-+izoXi6OPEuX_61wNw@mail.gmail.com>
Date: Wed, 23 Oct 2024 17:24:03 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Remi Denis-Courmont <courmisch@...il.com>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net-next 1/9] phonet: Pass ifindex to fill_addr().

On Thu, Oct 17, 2024 at 8:32 PM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> We will convert addr_doit() and getaddr_dumpit() to RCU, both
> of which call fill_addr().
>
> The former will call phonet_address_notify() outside of RCU
> due to GFP_KERNEL, so dev will not be available in fill_addr().
>
> Let's pass ifindex directly to fill_addr().
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>