netdev - Re: [PATCH v1 net-next 3/9] phonet: Convert phonet_device_list.lock to spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLyzO3d169JJ2ACDTnr_+XQBLsE-VSCDyDKZ4bXraLozw@mail.gmail.com>
Date: Wed, 23 Oct 2024 17:26:36 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Remi Denis-Courmont <courmisch@...il.com>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net-next 3/9] phonet: Convert phonet_device_list.lock
 to spinlock_t.

On Thu, Oct 17, 2024 at 8:32 PM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> addr_doit() calls phonet_address_add() or phonet_address_del()
> for RTM_NEWADDR or RTM_DELADDR, respectively.
>
> Both functions only touch phonet_device_list(dev_net(dev)),
> which is currently protected by RTNL and its dedicated mutex,
> phonet_device_list.lock.
>
> We will convert addr_doit() to RCU and cannot use mutex inside RCU.
>
> Let's convert the mutex to spinlock_t.
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>
> ---

Reviewed-by: Eric Dumazet <edumazet@...gle.com>