netdev - Re: [PATCH v2 iproute2-next 1/1] tc: add dualpi2 scheduler module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241023090110.559de7d3@hermes.local>
Date: Wed, 23 Oct 2024 09:01:10 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: chia-yu.chang@...ia-bell-labs.com
Cc: netdev@...r.kernel.org, dsahern@...il.com, davem@...emloft.net,
 jhs@...atatu.com, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 dsahern@...nel.org, ij@...nel.org, ncardwell@...gle.com,
 koen.de_schepper@...ia-bell-labs.com, g.white@...leLabs.com,
 ingemar.s.johansson@...csson.com, mirja.kuehlewind@...csson.com,
 cheshire@...le.com, rs.ietf@....at, Jason_Livingood@...cast.com,
 vidhi_goel@...le.com, Olga Albisser <olga@...isser.org>, Oliver Tilmans
 <olivier.tilmans@...ia.com>, Bob Briscoe <research@...briscoe.net>, Henrik
 Steen <henrist@...rist.net>
Subject: Re: [PATCH v2 iproute2-next 1/1] tc: add dualpi2 scheduler module

On Wed, 23 Oct 2024 13:04:34 +0200
chia-yu.chang@...ia-bell-labs.com wrote:

> +	if (tb[TCA_DUALPI2_SPLIT_GSO] &&
> +	    RTA_PAYLOAD(tb[TCA_DUALPI2_SPLIT_GSO]) >= sizeof(__u8)) {
> +		if (rta_getattr_u8(tb[TCA_DUALPI2_SPLIT_GSO]))
> +			print_bool(PRINT_ANY, "split_gso",
> +				   "split_gso ", true);
> +		else
> +			print_bool(PRINT_FP, NULL,
> +				   "no_split_gso ", true);
> +	}

Since split gso is a true/false value, then maybe something like:
	if (tb[TCA_DUALPI2_SPLIT_GSO]) {
		u8 split_gso = rta_getattr_u8(tb[TCA_DUALPI2_SPLIT_GSO]);

		print_string(PRINT_FP, NULL, "%ssplit_gso", split_gso ? "" : "no_");
		print_bool(PRINT_JSON, "split_gso", NULL, !!split_gso);
	}