netdev - Re: [PATCH v3 1/1] binder: report txn errors via generic netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202410240012.MJJTBFCx-lkp@intel.com>
Date: Thu, 24 Oct 2024 00:47:07 +0800
From: kernel test robot <lkp@...el.com>
To: Li Li <dualli@...omium.org>, dualli@...gle.com, corbet@....net,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, donald.hunter@...il.com,
	gregkh@...uxfoundation.org, arve@...roid.com, tkjos@...roid.com,
	maco@...roid.com, joel@...lfernandes.org, brauner@...nel.org,
	cmllamas@...gle.com, surenb@...gle.com, arnd@...db.de,
	masahiroy@...nel.org, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, netdev@...r.kernel.org,
	hridya@...gle.com, smoreland@...gle.com
Cc: oe-kbuild-all@...ts.linux.dev, kernel-team@...roid.com
Subject: Re: [PATCH v3 1/1] binder: report txn errors via generic netlink

Hi Li,

kernel test robot noticed the following build warnings:

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on staging/staging-next staging/staging-linus linus/master v6.12-rc4 next-20241023]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Li-Li/binder-report-txn-errors-via-generic-netlink/20241022-022923
base:   staging/staging-testing
patch link:    https://lore.kernel.org/r/20241021182821.1259487-2-dualli%40chromium.org
patch subject: [PATCH v3 1/1] binder: report txn errors via generic netlink
config: arc-allmodconfig (https://download.01.org/0day-ci/archive/20241024/202410240012.MJJTBFCx-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241024/202410240012.MJJTBFCx-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410240012.MJJTBFCx-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/android/binder_genl.c:160: warning: Function parameter or struct member 'context' not described in 'binder_genl_set_report'
>> drivers/android/binder_genl.c:160: warning: Excess function parameter 'proc' description in 'binder_genl_set_report'

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for GET_FREE_REGION
   Depends on [n]: SPARSEMEM [=n]
   Selected by [m]:
   - RESOURCE_KUNIT_TEST [=m] && RUNTIME_TESTING_MENU [=y] && KUNIT [=m]


vim +160 drivers/android/binder_genl.c

   149	
   150	/**
   151	 * binder_genl_set_report() - set binder report flags
   152	 * @proc:	the binder_proc calling the ioctl
   153	 * @pid:	the target process
   154	 * @flags:	the flags to set
   155	 *
   156	 * If pid is 0, the flags are applied to the whole binder context.
   157	 * Otherwise, the flags are applied to the specific process only.
   158	 */
   159	int binder_genl_set_report(struct binder_context *context, u32 pid, u32 flags)
 > 160	{
   161		struct binder_proc *proc;
   162	
   163		if (flags != (flags & (BINDER_REPORT_ALL | BINDER_REPORT_OVERRIDE))) {
   164			pr_err("Invalid binder report flags: %u\n", flags);
   165			return -EINVAL;
   166		}
   167	
   168		if (!pid) {
   169			/* Set the global flags for the whole binder context */
   170			context->report_flags = flags;
   171		} else {
   172			/* Set the per-process flags */
   173			proc = binder_find_proc(pid);
   174			if (!proc) {
   175				pr_err("Invalid binder report pid %u\n", pid);
   176				return -EINVAL;
   177			}
   178	
   179			proc->report_flags = flags;
   180		}
   181	
   182		return 0;
   183	}
   184	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki