netdev - Re: [PATCH net-next 4/8] selftests: net: lib: Move logging from forwarding/lib.sh here

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <477cac2e-606d-4c78-ba5e-ce7e594bb6f5@linuxfoundation.org>
Date: Wed, 23 Oct 2024 14:07:38 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Petr Machata <petrm@...dia.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Cc: Ido Schimmel <idosch@...dia.com>, Amit Cohen <amcohen@...dia.com>,
 Vladimir Oltean <vladimir.oltean@....com>, mlxsw@...dia.com,
 Shuah Khan <shuah@...nel.org>, Benjamin Poirier <bpoirier@...dia.com>,
 Hangbin Liu <liuhangbin@...il.com>, linux-kselftest@...r.kernel.org,
 Jiri Pirko <jiri@...nulli.us>, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH net-next 4/8] selftests: net: lib: Move logging from
 forwarding/lib.sh here

On 10/22/24 08:50, Petr Machata wrote:
> Many net selftests invent their own logging helpers. These really should be
> in a library sourced by these tests. Currently forwarding/lib.sh has a
> suite of perfectly fine logging helpers, but sourcing a forwarding/ library
> from a higher-level directory smells of layering violation. In this patch,
> move the logging helpers to net/lib.sh so that every net test can use them.
> 
> Together with the logging helpers, it's also necessary to move
> pause_on_fail(), and EXIT_STATUS and RET.
> 
> Existing lib.sh users might be using these same names for their functions
> or variables. However lib.sh is always sourced near the top of the
> file (checked), and whatever new definitions will simply override the ones
> provided by lib.sh.

I like the direction to leverage and make logging functions
common. It make sense to use prefix to clearly indicate
that they are common and to namespace conflicts in the future.

> 
> Signed-off-by: Petr Machata <petrm@...dia.com>
> Reviewed-by: Amit Cohen <amcohen@...dia.com>
> ---
> CC: Shuah Khan <shuah@...nel.org>

Acked-by: Shuah Khan <skhan@...uxfoundation.org>

for all patches 4/8 through 8/8 I have been cc'ed on.

thanks,
-- Shuah