netdev - 回复: [PATCH net v2] net: fix crash when config small gso_max_size/gso_ipv4_max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c9abbcbe45e845a59869d01253db6dd0@huawei.com>
Date: Wed, 23 Oct 2024 07:18:32 +0000
From: "wangliang (CI)" <wangliang74@...wei.com>
To: Eric Dumazet <edumazet@...gle.com>
CC: "davem@...emloft.net" <davem@...emloft.net>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"idosch@...dia.com" <idosch@...dia.com>, "kuniyu@...zon.com"
	<kuniyu@...zon.com>, "stephen@...workplumber.org"
	<stephen@...workplumber.org>, "dsahern@...nel.org" <dsahern@...nel.org>,
	"lucien.xin@...il.com" <lucien.xin@...il.com>, yuehaibing
	<yuehaibing@...wei.com>, zhangchangzhong <zhangchangzhong@...wei.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: 回复: [PATCH net v2] net: fix crash when config small gso_max_size/gso_ipv4_max_size

Thank you very much for your suggestions!

-----邮件原件-----
发件人: Eric Dumazet <edumazet@...gle.com> 
发送时间: 2024年10月23日 14:44
收件人: wangliang (CI) <wangliang74@...wei.com>
抄送: davem@...emloft.net; kuba@...nel.org; pabeni@...hat.com; idosch@...dia.com; kuniyu@...zon.com; stephen@...workplumber.org; dsahern@...nel.org; lucien.xin@...il.com; yuehaibing <yuehaibing@...wei.com>; zhangchangzhong <zhangchangzhong@...wei.com>; netdev@...r.kernel.org; linux-kernel@...r.kernel.org
主题: Re: [PATCH net v2] net: fix crash when config small gso_max_size/gso_ipv4_max_size

On Wed, Oct 23, 2024 at 5:34 AM Wang Liang <wangliang74@...wei.com> wrote:
>
> Config a small gso_max_size/gso_ipv4_max_size will lead to an 
> underflow in sk_dst_gso_max_size(), which may trigger a BUG_ON crash, 
> because sk->sk_gso_max_size would be much bigger than device limits.
> Call Trace:
> tcp_write_xmit
>     tso_segs = tcp_init_tso_segs(skb, mss_now);
>         tcp_set_skb_tso_segs
>             tcp_skb_pcount_set
>                 // skb->len = 524288, mss_now = 8
>                 // u16 tso_segs = 524288/8 = 65535 -> 0
>                 tso_segs = DIV_ROUND_UP(skb->len, mss_now)
>     BUG_ON(!tso_segs)
> Add check for the minimum value of gso_max_size and gso_ipv4_max_size.
>
> Fixes: 46e6b992c250 ("rtnetlink: allow GSO maximums to be set on 
> device creation")
> Fixes: 9eefedd58ae1 ("net: add gso_ipv4_max_size and gro_ipv4_max_size 
> per device")
> Signed-off-by: Wang Liang <wangliang74@...wei.com>
> ---

Thanks for this fix !

Reviewed-by: Eric Dumazet <edumazet@...gle.com>