netdev - Re: [PATCH net-next] amd-xgbe: use ethtool string helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73040aee-7584-4d7e-a3c1-edc12a85f5e1@amd.com>
Date: Wed, 23 Oct 2024 13:02:08 +0530
From: Shyam Sundar S K <Shyam-sundar.S-k@....com>
To: Rosen Penev <rosenp@...il.com>, netdev@...r.kernel.org
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] amd-xgbe: use ethtool string helpers



On 10/23/2024 05:02, Rosen Penev wrote:
> The latter is the preferred way to copy ethtool strings.
> 
> Avoids manually incrementing the pointer.
> 
> Signed-off-by: Rosen Penev <rosenp@...il.com>

Looks good to me.

Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@....com>

Thanks,
Shyam

> ---
>  drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c | 22 ++++++++------------
>  1 file changed, 9 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c b/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c
> index 5fc94c2f638e..4431ab1c18b3 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c
> @@ -195,23 +195,19 @@ static void xgbe_get_strings(struct net_device *netdev, u32 stringset, u8 *data)
>  
>  	switch (stringset) {
>  	case ETH_SS_STATS:
> -		for (i = 0; i < XGBE_STATS_COUNT; i++) {
> -			memcpy(data, xgbe_gstring_stats[i].stat_string,
> -			       ETH_GSTRING_LEN);
> -			data += ETH_GSTRING_LEN;
> -		}
> +		for (i = 0; i < XGBE_STATS_COUNT; i++)
> +			ethtool_puts(&data, xgbe_gstring_stats[i].stat_string);
> +
>  		for (i = 0; i < pdata->tx_ring_count; i++) {
> -			sprintf(data, "txq_%u_packets", i);
> -			data += ETH_GSTRING_LEN;
> -			sprintf(data, "txq_%u_bytes", i);
> -			data += ETH_GSTRING_LEN;
> +			ethtool_sprintf(&data, "txq_%u_packets", i);
> +			ethtool_sprintf(&data, "txq_%u_bytes", i);
>  		}
> +
>  		for (i = 0; i < pdata->rx_ring_count; i++) {
> -			sprintf(data, "rxq_%u_packets", i);
> -			data += ETH_GSTRING_LEN;
> -			sprintf(data, "rxq_%u_bytes", i);
> -			data += ETH_GSTRING_LEN;
> +			ethtool_sprintf(&data, "rxq_%u_packets", i);
> +			ethtool_sprintf(&data, "rxq_%u_bytes", i);
>  		}
> +
>  		break;
>  	}
>  }