netdev - Re: [PATCH net-next] bareudp: Use pcpu stats to update rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241023081225.GK402847@kernel.org>
Date: Wed, 23 Oct 2024 09:12:25 +0100
From: Simon Horman <horms@...nel.org>
To: Guillaume Nault <gnault@...hat.com>
Cc: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] bareudp: Use pcpu stats to update rx_dropped
 counter.

On Fri, Oct 18, 2024 at 03:35:28PM +0200, Guillaume Nault wrote:
> Use the core_stats rx_dropped counter to avoid the cost of atomic
> increments.
> 
> Signed-off-by: Guillaume Nault <gnault@...hat.com>
> ---
> I'm using core_stats for consistency with the vxlan implementation.
> If we really want to avoid using core_stats in tunnel drivers, just
> let me know and I'll convert bareudp to NETDEV_PCPU_STAT_DSTATS. But
> for the moment, I still prefer to favor code consistency across UDP
> tunnel implementations.

Hi Guillaume, all,

I think that this patch improves things and the suggestion above
can be treated as a possible follow-up.

Reviewed-by: Simon Horman <horms@...nel.org>