netdev - Re: [net-next,RESEND v6 2/2] net: wwan: t7xx: Add debug port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20241023151514.GA888712@bhelgaas>
Date: Thu, 24 Oct 2024 18:07:25 +0800
From: Jinjian Song <jinjian.song@...ocom.com>
To: helgaas@...nel.org
Cc: angelogioacchino.delregno@...labora.com,
	chandrashekar.devegowda@...el.com,
	chiranjeevi.rapolu@...ux.intel.com,
	corbet@....net,
	danielwinkler@...gle.com,
	davem@...emloft.net,
	edumazet@...gle.com,
	haijun.liu@...iatek.com,
	jinjian.song@...ocom.com,
	johannes@...solutions.net,
	korneld@...gle.com,
	kuba@...nel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	linux-mediatek@...ts.infradead.org,
	loic.poulain@...aro.org,
	m.chetan.kumar@...ux.intel.com,
	matthias.bgg@...il.com,
	netdev@...r.kernel.org,
	pabeni@...hat.com,
	ricardo.martinez@...ux.intel.com,
	ryazanov.s.a@...il.com,
	songjinjian@...mail.com
Subject: Re: [net-next,RESEND v6 2/2] net: wwan: t7xx: Add debug port

>On Mon, Oct 21, 2024 at 08:19:34PM +0800, Jinjian Song wrote:
>> From: Jinjian Song <songjinjian@...mail.com>
>> 
>> Add support for userspace to switch on the debug port(ADB,MIPC).
>>  - ADB port: /dev/wwan0adb0
>>  - MIPC port: /dev/wwan0mipc0
>> 
>> Application can use ADB (Android Debg Bridge) port to implement
>> functions (shell, pull, push ...) by ADB protocol commands.
>> E.g., ADB commands:
>>  - A_OPEN: OPEN(local-id, 0, "destination")
>>  - A_WRTE: WRITE(local-id, remote-id, "data")
>>  - A_OKEY: READY(local-id, remote-id, "")
>>  - A_CLSE: CLOSE(local-id, remote-id, "")
>
>s/Debg/Debug/

Got it, thanks.

>> Link: https://android.googlesource.com/platform/packages/modules/adb/+/refs/heads/main/README.md
>> 
>> Application can use MIPC (Modem Information Process Center) port
>> to debug antenna tunner or noise profiling through this MTK modem
>> diagnostic interface.
>
>s/tunner/tuner/

Got it, thanks.

>> +++ b/Documentation/networking/device_drivers/wwan/t7xx.rst
>> @@ -67,6 +67,28 @@ Write from userspace to set the device mode.
>>  ::
>>    $ echo fastboot_switching > /sys/bus/pci/devices/${bdf}/t7xx_mode
>>  
>> +t7xx_port_mode
>> +--------------
>> +The sysfs interface provides userspace with access to the port mode, this interface
>> +supports read and write operations.
>
>This file is not completely consistent, but 90% of it fits in 80
>columns, so I would make your additions fit also.
>

Please let me change this file.

Best Regards,
Jinjian