netdev - Re: [RFC PATCH 1/2] net: netlink: add nla_get_*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87seslfyv8.fsf@toke.dk>
Date: Thu, 24 Oct 2024 14:51:07 +0200
From: Toke Høiland-Jørgensen <toke@...nel.org>
To: Johannes Berg <johannes@...solutions.net>,
 linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Cc: Johannes Berg <johannes.berg@...el.com>
Subject: Re: [RFC PATCH 1/2] net: netlink: add nla_get_*_default() accessors

Johannes Berg <johannes@...solutions.net> writes:

> From: Johannes Berg <johannes.berg@...el.com>
>
> There are quite a number of places that use patterns
> such as
>
>   if (attr)
>      val = nla_get_u16(attr);
>   else
>      val = DEFAULT;
>
> Add nla_get_u16_default() and friends like that to
> not have to type this out all the time.
>
> Signed-off-by: Johannes Berg <johannes.berg@...el.com>

I think this is an excellent idea! So typos/copy-paste errors aside:

Acked-by: Toke Høiland-Jørgensen <toke@...nel.org>