netdev - Re: [PATCH net v2] igb: Fix potential invalid memory access in igb_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241024132758.GN1202098@kernel.org>
Date: Thu, 24 Oct 2024 14:27:58 +0100
From: Simon Horman <horms@...nel.org>
To: Yuan Can <yuancan@...wei.com>
Cc: anthony.l.nguyen@...el.com, przemyslaw.kitszel@...el.com,
	andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, alexander.h.duyck@...el.com,
	intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org
Subject: Re: [PATCH net v2] igb: Fix potential invalid memory access in
 igb_init_module()

On Wed, Oct 23, 2024 at 08:10:48PM +0800, Yuan Can wrote:
> The pci_register_driver() can fail and when this happened, the dca_notifier
> needs to be unregistered, otherwise the dca_notifier can be called when
> igb fails to install, resulting to invalid memory access.
> 
> Fixes: bbd98fe48a43 ("igb: Fix DCA errors and do not use context index for 82576")
> Signed-off-by: Yuan Can <yuancan@...wei.com>
> ---
> Changes since v1:
> - Change fix tag to bbd98fe48a43.
> - Change target branch to net.

Thanks for the updates.

Reviewed-by: Simon Horman <horms@...nel.org>