[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <891519a9-9635-4a6f-804a-5b4c0d7637d9@huawei.com>
Date: Thu, 24 Oct 2024 11:45:55 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Andrew Lunn <andrew@...n.ch>
CC: <shaojijie@...wei.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
<kuba@...nel.org>, <pabeni@...hat.com>, <andrew+netdev@...n.ch>,
<horms@...nel.org>, <shenjian15@...wei.com>, <wangpeiyang1@...wei.com>,
<liuyonglong@...wei.com>, <chenhao418@...wei.com>, <sudongming1@...wei.com>,
<xujunsheng@...wei.com>, <shiyongbang@...wei.com>, <libaihan@...wei.com>,
<jonathan.cameron@...wei.com>, <shameerali.kolothum.thodi@...wei.com>,
<salil.mehta@...wei.com>, <netdev@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 5/7] net: hibmcge: Add pauseparam supported in
this module
on 2024/10/23 22:15, Andrew Lunn wrote:
>> +static int hbg_ethtool_set_pauseparam(struct net_device *net_dev,
>> + struct ethtool_pauseparam *param)
>> +{
>> + struct hbg_priv *priv = netdev_priv(net_dev);
>> +
>> + if (param->autoneg) {
>> + netdev_err(net_dev, "autoneg unsupported\n");
>> + return -EOPNOTSUPP;
>> + }
> Not being able to do it is not an error, so there is no need for the
> netdev_err().
Ok, Thanks!
>
>
> Andrew
>
> ---
> pw-bot: cr
>
Powered by blists - more mailing lists