netdev - Re: RFC: Advice on adding support for Qualcomm IPQ9574 SoC Ethernet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28409cbc-09c8-4c88-b11e-2c46457c9e8e@lunn.ch>
Date: Thu, 24 Oct 2024 16:27:31 +0200
From: Andrew Lunn <andrew@...n.ch>
To: "Kiran Kumar C.S.K" <quic_kkumarcs@...cinc.com>
Cc: "Russell King (Oracle)" <linux@...linux.org.uk>, netdev@...r.kernel.org,
	Andy Gross <agross@...nel.org>,
	Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konrad.dybcio@...aro.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Jacob Keller <jacob.e.keller@...el.com>,
	Bhupesh Sharma <bhupesh.sharma@...aro.org>,
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, vsmuthu@....qualcomm.com,
	arastogi@....qualcomm.com, linchen@....qualcomm.com,
	john@...ozen.org, Luo Jie <quic_luoj@...cinc.com>,
	Pavithra R <quic_pavir@...cinc.com>,
	"Suruchi Agarwal (QUIC)" <quic_suruchia@...cinc.com>,
	"Lei Wei (QUIC)" <quic_leiwei@...cinc.com>
Subject: Re: RFC: Advice on adding support for Qualcomm IPQ9574 SoC Ethernet

> > I'm just wondering if you have circular dependencies at runtime?
> > 
> > Where you will need to be careful is probe time vs runtime. Since you
> > have circular phandles you need to first create all the clock
> > providers, and only then start the clock consumers. Otherwise you
> > might get into an endless EPROBE_DEFER loop.
> > 
> 
> The Rx/Tx clocks sourced from the SERDES are registered as provider
> clocks by the UNIPHY/PCS driver during probe time. There is no runtime
> operation needed for these clocks after this.

So they are always ticking. You cannot turn them on/off? It is nice to
model them a fixed-clocks, since it describes the architecture, but i
have to question if it is worth the effort.

	Andrew