netdev - Re: [PATCH net-next] Documentation: networking: Add missing PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241024152816.GA1202098@kernel.org>
Date: Thu, 24 Oct 2024 16:28:16 +0100
From: Simon Horman <horms@...nel.org>
To: Kory Maincent <kory.maincent@...tlin.com>
Cc: netdev@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Maxime Chevallier <maxime.chevallier@...tlin.com>,
	thomas.petazzoni@...tlin.com,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Jonathan Corbet <corbet@....net>
Subject: Re: [PATCH net-next] Documentation: networking: Add missing PHY_GET
 command in the message list

On Thu, Oct 24, 2024 at 05:18:02PM +0200, Kory Maincent wrote:
> On Thu, 24 Oct 2024 15:52:23 +0100
> Simon Horman <horms@...nel.org> wrote:
> 
> > On Wed, Oct 23, 2024 at 04:15:58PM +0200, Kory Maincent wrote:
> > > ETHTOOL_MSG_PHY_GET/GET_REPLY/NTF is missing in the ethtool message list.
> > > Add it to the ethool netlink documentation.
> > > 
> > > Signed-off-by: Kory Maincent <kory.maincent@...tlin.com>
> > > ---
> > >  Documentation/networking/ethtool-netlink.rst | 3 +++
> > >  1 file changed, 3 insertions(+)
> > > 
> > > diff --git a/Documentation/networking/ethtool-netlink.rst
> > > b/Documentation/networking/ethtool-netlink.rst index
> > > 295563e91082..70ecc3821007 100644 ---
> > > a/Documentation/networking/ethtool-netlink.rst +++
> > > b/Documentation/networking/ethtool-netlink.rst @@ -236,6 +236,7 @@
> > > Userspace to kernel: ``ETHTOOL_MSG_MM_GET``                get MAC merge
> > > layer state ``ETHTOOL_MSG_MM_SET``                set MAC merge layer
> > > parameters ``ETHTOOL_MSG_MODULE_FW_FLASH_ACT``   flash transceiver module
> > > firmware
> > > +  ``ETHTOOL_MSG_PHY_GET``               get Ethernet PHY information
> > >    ===================================== =================================
> > >  
> > >  Kernel to userspace:
> > > @@ -283,6 +284,8 @@ Kernel to userspace:
> > >    ``ETHTOOL_MSG_PLCA_NTF``                 PLCA RS parameters
> > >    ``ETHTOOL_MSG_MM_GET_REPLY``             MAC merge layer status
> > >    ``ETHTOOL_MSG_MODULE_FW_FLASH_NTF``      transceiver module flash updates
> > > +  ``ETHTOOL_MSG_PHY_GET_REPLY``            Ethernet PHY information
> > > +  ``ETHTOOL_MSG_PHY_NTF``                  Ethernet PHY information  
> > 
> > I wonder if ETHTOOL_MSG_PHY_NTF should be removed.
> > It doesn't seem to be used anywhere.
> 
> We can't, as it is in the ethtool UAPI. Also I believe Maxime will use it on
> later patch series. Maxime, you confirm?

Ok, if it's in the UAPI then I suppose it needs to stay.

But could we differentiate in the documentation between
ETHTOOL_MSG_PHY_GET_REPLY and ETHTOOL_MSG_PHY_NTF?