netdev - Re: [PATCH v2 RESEND] net/mlx5: unique names for per device caches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4e3fbf05-3a88-43be-826c-a16a6718217f@gmail.com>
Date: Thu, 24 Oct 2024 19:47:54 +0300
From: Tariq Toukan <ttoukan.linux@...il.com>
To: Sebastian Ott <sebott@...hat.com>, netdev@...r.kernel.org,
 linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>,
 Tariq Toukan <tariqt@...dia.com>, "David S . Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Parav Pandit <parav@...dia.com>,
 Breno Leitao <leitao@...ian.org>
Subject: Re: [PATCH v2 RESEND] net/mlx5: unique names for per device caches



On 23/10/2024 16:41, Sebastian Ott wrote:
> Add the device name to the per device kmem_cache names to
> ensure their uniqueness. This fixes warnings like this:
> "kmem_cache of name 'mlx5_fs_fgs' already exists".
> 
> Reviwed-by: Breno Leitao <leitao@...ian.org>
> Signed-off-by: Sebastian Ott <sebott@...hat.com>
> ---
>   drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
> index 8505d5e241e1..c2db0a1c132b 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
> @@ -3689,6 +3689,7 @@ void mlx5_fs_core_free(struct mlx5_core_dev *dev)
>   int mlx5_fs_core_alloc(struct mlx5_core_dev *dev)
>   {
>   	struct mlx5_flow_steering *steering;
> +	char name[80];
>   	int err = 0;
>   
>   	err = mlx5_init_fc_stats(dev);
> @@ -3713,10 +3714,12 @@ int mlx5_fs_core_alloc(struct mlx5_core_dev *dev)
>   	else
>   		steering->mode = MLX5_FLOW_STEERING_MODE_DMFS;
>   
> -	steering->fgs_cache = kmem_cache_create("mlx5_fs_fgs",
> +	snprintf(name, sizeof(name), "%s-mlx5_fs_fgs", dev_name(dev->device));
> +	steering->fgs_cache = kmem_cache_create(name,
>   						sizeof(struct mlx5_flow_group), 0,
>   						0, NULL);
> -	steering->ftes_cache = kmem_cache_create("mlx5_fs_ftes", sizeof(struct fs_fte), 0,
> +	snprintf(name, sizeof(name), "%s-mlx5_fs_ftes", dev_name(dev->device));
> +	steering->ftes_cache = kmem_cache_create(name, sizeof(struct fs_fte), 0,
>   						 0, NULL);
>   	if (!steering->ftes_cache || !steering->fgs_cache) {
>   		err = -ENOMEM;

Reviewed-by: Tariq Toukan <tariqt@...dia.com>

Thanks.