netdev - Re: [PATCH net-next 2/2] net/mlx5e: Update features on ring size change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241025085220.GF1202098@kernel.org>
Date: Fri, 25 Oct 2024 09:52:20 +0100
From: Simon Horman <horms@...nel.org>
To: Tariq Toukan <tariqt@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, netdev@...r.kernel.org,
	Saeed Mahameed <saeedm@...dia.com>, Gal Pressman <gal@...dia.com>,
	Leon Romanovsky <leonro@...dia.com>,
	Dragos Tatulea <dtatulea@...dia.com>
Subject: Re: [PATCH net-next 2/2] net/mlx5e: Update features on ring size
 change

On Thu, Oct 24, 2024 at 07:41:33PM +0300, Tariq Toukan wrote:
> From: Dragos Tatulea <dtatulea@...dia.com>
> 
> When the ring size changes successfully, trigger
> netdev_update_features() to enable features in wanted state if
> applicable.
> 
> An example of such scenario:
> $ ip link set dev eth1 up
> $ ethtool --set-ring eth1 rx 8192
> $ ip link set dev eth1 mtu 9000
> $ ethtool --features eth1 rx-gro-hw on --> fails
> $ ethtool --set-ring eth1 rx 1024
> 
> With this patch, HW GRO will be turned on automatically because
> it is set in the device's wanted_features.
> 
> Signed-off-by: Dragos Tatulea <dtatulea@...dia.com>
> Reviewed-by: Gal Pressman <gal@...dia.com>
> Signed-off-by: Tariq Toukan <tariqt@...dia.com>

Reviewed-by: Simon Horman <horms@...nel.org>