netdev - Re: [PATCH net-next] gve: change to use page_pool_put_full

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241025090913.GI1202098@kernel.org>
Date: Fri, 25 Oct 2024 10:09:13 +0100
From: Simon Horman <horms@...nel.org>
To: Harshitha Ramamurthy <hramamurthy@...gle.com>
Cc: Yunsheng Lin <linyunsheng@...wei.com>,
	Praveen Kaligineedi <pkaligineedi@...gle.com>,
	netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, andrew+netdev@...n.ch,
	willemb@...gle.com, jeroendb@...gle.com, shailend@...gle.com,
	ziweixiao@...gle.com, jacob.e.keller@...el.com
Subject: Re: [PATCH net-next] gve: change to use page_pool_put_full_page when
 recycling pages

On Thu, Oct 24, 2024 at 10:58:47AM -0700, Harshitha Ramamurthy wrote:
> On Thu, Oct 24, 2024 at 8:45 AM Simon Horman <horms@...nel.org> wrote:
> >
> > On Thu, Oct 24, 2024 at 10:36:02AM +0800, Yunsheng Lin wrote:
> > > On 2024/10/24 6:11, Praveen Kaligineedi wrote:
> > > > From: Harshitha Ramamurthy <hramamurthy@...gle.com>
> > > >
> > > > The driver currently uses page_pool_put_page() to recycle
> > > > page pool pages. Since gve uses split pages, if the fragment
> > > > being recycled is not the last fragment in the page, there
> > > > is no dma sync operation. When the last fragment is recycled,
> > > > dma sync is performed by page pool infra according to the
> > > > value passed as dma_sync_size which right now is set to the
> > > > size of fragment.
> > > >
> > > > But the correct thing to do is to dma sync the entire page when
> > > > the last fragment is recycled. Hence change to using
> > > > page_pool_put_full_page().
> > >
> > > I am not sure if Fixes tag is needed if the blamed commit is only
> > > in the net-next tree. Otherwise, LGTM.
> >
> > I think it would be best to provide a fixes tag in this case.
> > It can be done by supplying it in a response to this email thread.
> > (I think it needs to start at the beginning of a line.)
> 
> Thanks Yunsheng and Simon. I wasn't sure since this patch was targeted
> for net-next. I have provided a Fixes tag below.

Thanks. FWIIW, the tag looks correct to me.

> >
> > > Reviewed-by: Yunsheng Lin <linyunsheng@...wei.com>
> > >
> > > >
> > > > Link: https://lore.kernel.org/netdev/89d7ce83-cc1d-4791-87b5-6f7af29a031d@huawei.com/
> > > >
> Fixes: ebdfae0d377b ("gve: adopt page pool for DQ RDA mode")
> > > > Suggested-by: Yunsheng Lin <linyunsheng@...wei.com>
> > > > Reviewed-by: Praveen Kaligineedi <pkaligineedi@...gle.com>
> > > > Reviewed-by: Willem de Bruijn <willemb@...gle.com>
> > > > Signed-off-by: Harshitha Ramamurthy <hramamurthy@...gle.com>
> >
> > ...
>