netdev - Re: [PATCH net-next 4/7] net: hibmcge: Add register dump supported in this module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202410251738.mRleD5uf-lkp@intel.com>
Date: Fri, 25 Oct 2024 17:25:04 +0800
From: kernel test robot <lkp@...el.com>
To: Jijie Shao <shaojijie@...wei.com>, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	andrew+netdev@...n.ch, horms@...nel.org
Cc: oe-kbuild-all@...ts.linux.dev, shenjian15@...wei.com,
	wangpeiyang1@...wei.com, liuyonglong@...wei.com,
	chenhao418@...wei.com, sudongming1@...wei.com,
	xujunsheng@...wei.com, shiyongbang@...wei.com, libaihan@...wei.com,
	jonathan.cameron@...wei.com, shameerali.kolothum.thodi@...wei.com,
	salil.mehta@...wei.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, shaojijie@...wei.com
Subject: Re: [PATCH net-next 4/7] net: hibmcge: Add register dump supported
 in this module

Hi Jijie,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Jijie-Shao/net-hibmcge-Add-dump-statistics-supported-in-this-module/20241023-215222
base:   net-next/main
patch link:    https://lore.kernel.org/r/20241023134213.3359092-5-shaojijie%40huawei.com
patch subject: [PATCH net-next 4/7] net: hibmcge: Add register dump supported in this module
config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20241025/202410251738.mRleD5uf-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241025/202410251738.mRleD5uf-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410251738.mRleD5uf-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/hisilicon/hibmcge/hbg_ethtool.c: In function 'hbg_ethtool_get_regs':
>> drivers/net/ethernet/hisilicon/hibmcge/hbg_ethtool.c:322:20: warning: '%s' directive output may be truncated writing up to 127 bytes into a region of size 31 [-Wformat-truncation=]
     322 |                  "[%s] %s", type_info->name, reg_map->name);
         |                    ^~
   In function 'hbg_get_reg_info',
       inlined from 'hbg_ethtool_get_regs' at drivers/net/ethernet/hisilicon/hibmcge/hbg_ethtool.c:338:14:
   drivers/net/ethernet/hisilicon/hibmcge/hbg_ethtool.c:321:9: note: 'snprintf' output between 4 and 154 bytes into a destination of size 32
     321 |         snprintf(info->name, sizeof(info->name),
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     322 |                  "[%s] %s", type_info->name, reg_map->name);
         |                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +322 drivers/net/ethernet/hisilicon/hibmcge/hbg_ethtool.c

   313	
   314	static u32 hbg_get_reg_info(struct hbg_priv *priv,
   315				    const struct hbg_reg_type_info *type_info,
   316				    const struct hbg_reg_offset_name_map *reg_map,
   317				    struct hbg_reg_info *info)
   318	{
   319		info->val = hbg_reg_read(priv, reg_map->reg_offset);
   320		info->offset = reg_map->reg_offset - type_info->offset_base;
   321		snprintf(info->name, sizeof(info->name),
 > 322			 "[%s] %s", type_info->name, reg_map->name);
   323	
   324		return sizeof(*info);
   325	}
   326	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki