netdev - Re: [PATCH net-next] r8169: add support for RTL8125D

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9fece96e-9a38-4b97-93d9-885a5d8800cc@gmail.com>
Date: Fri, 25 Oct 2024 13:44:48 +0200
From: Heiner Kallweit <hkallweit1@...il.com>
To: Simon Horman <horms@...nel.org>
Cc: Realtek linux nic maintainers <nic_swsd@...ltek.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, Paolo Abeni <pabeni@...hat.com>,
 Jakub Kicinski <kuba@...nel.org>, David Miller <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] r8169: add support for RTL8125D

On 25.10.2024 13:25, Simon Horman wrote:
> On Thu, Oct 24, 2024 at 10:42:33PM +0200, Heiner Kallweit wrote:
>> This adds support for new chip version RTL8125D, which can be found on
>> boards like Gigabyte X870E AORUS ELITE WIFI7. Firmware rtl8125d-1.fw
>> for this chip version is available in linux-firmware already.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> 
> Reviewed-by: Simon Horman <horms@...nel.org>
> 
> ...
> 
>> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
> 
> ...
> 
>> @@ -3872,6 +3873,12 @@ static void rtl_hw_start_8125b(struct rtl8169_private *tp)
>>  	rtl_hw_start_8125_common(tp);
>>  }
>>  
>> +static void rtl_hw_start_8125d(struct rtl8169_private *tp)
>> +{
>> +	rtl_set_def_aspm_entry_latency(tp);
>> +	rtl_hw_start_8125_common(tp);
>> +}
>> +
>>  static void rtl_hw_start_8126a(struct rtl8169_private *tp)
> 
> Maybe as a follow-up, rtl_hw_start_8125d and rtl_hw_start_8126a could
> be consolidated. They seem to be the same.
> 
Thanks for the review. Yes, for now they are the same. Both chip versions are new
and once there are enough users, I wouldn't be surprised if we need version-specific
tweaks to work around compatibility issues on certain systems.
Therefore the separate versions for the time being.

> ...