[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <6955c8b6-58df-4b1a-bdd6-759de3d3c46b@roeck-us.net>
Date: Fri, 25 Oct 2024 07:22:08 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Antoniu Miclaus <antoniu.miclaus@...log.com>,
Jean Delvare <jdelvare@...e.com>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, linux-hwmon@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Oleksij Rempel <o.rempel@...gutronix.de>,
Kory Maincent <kory.maincent@...tlin.com>,
Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH 2/2] hwmon: ltc4296-1: add driver support
Hi,
On 10/25/24 04:56, Antoniu Miclaus wrote:
> Add support for LTC4296-1 is an IEEE 802.3cg-compliant,
> five port, single-pair power over Ethernet (SPoE), power
> sourcing equipment (PSE) controller.
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@...log.com>
> ---
...
> + hwmon_dev = devm_hwmon_device_register_with_groups(&spi->dev,
> + spi->modalias,
> + st, ltc4296_1_groups);
New drivers must use the the with_info() hardware monitoring API.
The API use is inappropriate: _enable attributes are supposed to enable
monitoring, not a power source. The hardware monitoring subsystem is
responsible for hardware _monitoring_, not control. It can be tied to
the regulator subsystem, but even that seems to be be inappropriate here.
I think the driver should probably reside in drivers/net/pse-pd/.
That doesn't mean it can not support hardware monitoring, but that
isn't really the chip's primary functionality.
Yes, I see that we already have ti,tps23861 in the hardware monitoring
subsystem, but that may be just as wrong.
I am copying the PSE subsystem maintainers and mailing list for advice.
Thanks,
Guenter
Powered by blists - more mailing lists