netdev - RE: [PATCH v2 3/4] can: Add driver for CAST CAN Bus Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <ZQ2PR01MB1307D96BB8AC0B6BB78C97C9E64F2@ZQ2PR01MB1307.CHNPR01.prod.partner.outlook.cn>
Date: Fri, 25 Oct 2024 01:45:30 +0000
From: Hal Feng <hal.feng@...rfivetech.com>
To: Marc Kleine-Budde <mkl@...gutronix.de>
CC: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Vincent Mailhol
	<mailhol.vincent@...adoo.fr>, "David S . Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Philipp Zabel <p.zabel@...gutronix.de>, Palmer Dabbelt
	<palmer@...belt.com>, Paul Walmsley <paul.walmsley@...ive.com>, Albert Ou
	<aou@...s.berkeley.edu>, Emil Renner Berthing
	<emil.renner.berthing@...onical.com>, William Qiu
	<william.qiu@...rfivetech.com>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-can@...r.kernel.org"
	<linux-can@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-riscv@...ts.infradead.org"
	<linux-riscv@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 3/4] can: Add driver for CAST CAN Bus Controller

On 9/23/2024 5:14 AM, Marc Kleine-Budde wrote: 
> On 22.09.2024 22:51:49, Hal Feng wrote:
> > From: William Qiu <william.qiu@...rfivetech.com>
> >
> > Add driver for CAST CAN Bus Controller used on StarFive JH7110 SoC.
> 
> Have you read me review of the v1 of this series?
> 
> https://lore.kernel.org/all/20240129-zone-defame-c5580e596f72-
> mkl@...gutronix.de/

Yes, I modify accordingly except using FIELD_GET() / FIELD_PREP(), using
rx_offload helper and the shared interrupt flag. I found FIELD_GET() / FIELD_PREP()
can only be used when the mask is a constant, and the CAN module won't
work normally if I change the interrupt flag to 0. I will try to using rx_offload helper
in the next version.

Best regards,
Hal