netdev - Re: [PATCH net-next v4 3/6] net: stmmac: Refactor FPE functions to generic version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202410260025.sME33DwY-lkp@intel.com>
Date: Sat, 26 Oct 2024 01:10:17 +0800
From: kernel test robot <lkp@...el.com>
To: Furong Xu <0x1207@...il.com>, netdev@...r.kernel.org,
	linux-stm32@...md-mailman.stormreply.com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, Vladimir Oltean <olteanv@...il.com>,
	Andrew Lunn <andrew@...n.ch>, Simon Horman <horms@...nel.org>,
	andrew+netdev@...n.ch,
	Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Jose Abreu <joabreu@...opsys.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Maxime Coquelin <mcoquelin.stm32@...il.com>, xfr@...look.com,
	Furong Xu <0x1207@...il.com>
Subject: Re: [PATCH net-next v4 3/6] net: stmmac: Refactor FPE functions to
 generic version

Hi Furong,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Furong-Xu/net-stmmac-Introduce-separate-files-for-FPE-implementation/20241024-163526
base:   net-next/main
patch link:    https://lore.kernel.org/r/cfc647f0d031517f9ec9095235a574aad9dc2c95.1729757625.git.0x1207%40gmail.com
patch subject: [PATCH net-next v4 3/6] net: stmmac: Refactor FPE functions to generic version
config: arm-spear13xx_defconfig (https://download.01.org/0day-ci/archive/20241026/202410260025.sME33DwY-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241026/202410260025.sME33DwY-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410260025.sME33DwY-lkp@intel.com/

All errors (new ones prefixed by >>):

   arm-linux-gnueabi-ld: drivers/net/ethernet/stmicro/stmmac/stmmac_fpe.o: in function `stmmac_fpe_configure':
>> drivers/net/ethernet/stmicro/stmmac/stmmac_fpe.c:205:(.text+0x154): undefined reference to `__ffsdi2'


vim +205 drivers/net/ethernet/stmicro/stmmac/stmmac_fpe.c

   191	
   192	void stmmac_fpe_configure(struct stmmac_priv *priv, u32 num_txq, u32 num_rxq,
   193				  bool tx_enable, bool pmac_enable)
   194	{
   195		struct stmmac_fpe_cfg *cfg = &priv->fpe_cfg;
   196		const struct stmmac_fpe_reg *reg = cfg->reg;
   197		void __iomem *ioaddr = priv->ioaddr;
   198		u32 value;
   199	
   200		if (tx_enable) {
   201			cfg->fpe_csr = STMMAC_MAC_FPE_CTRL_STS_EFPE;
   202			value = readl(ioaddr + reg->rxq_ctrl1_reg);
   203			value &= ~reg->fprq_mask;
   204			/* Keep this SHIFT, FIELD_PREP() expects a constant mask :-/ */
 > 205			value |= (num_rxq - 1) << __bf_shf(reg->fprq_mask);
   206			writel(value, ioaddr + reg->rxq_ctrl1_reg);
   207		} else {
   208			cfg->fpe_csr = 0;
   209		}
   210		writel(cfg->fpe_csr, ioaddr + reg->mac_fpe_reg);
   211	
   212		value = readl(ioaddr + reg->int_en_reg);
   213	
   214		if (pmac_enable) {
   215			if (!(value & reg->int_en_bit)) {
   216				/* Dummy read to clear any pending masked interrupts */
   217				readl(ioaddr + reg->mac_fpe_reg);
   218	
   219				value |= reg->int_en_bit;
   220			}
   221		} else {
   222			value &= ~reg->int_en_bit;
   223		}
   224	
   225		writel(value, ioaddr + reg->int_en_reg);
   226	}
   227	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki