netdev - Re: [PATCH net-next v2 6/6] docs: networking: Describe irq suspension

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZxruYJizjXR8KUz0@archie.me>
Date: Fri, 25 Oct 2024 08:03:28 +0700
From: Bagas Sanjaya <bagasdotme@...il.com>
To: Joe Damato <jdamato@...tly.com>,
	Linux Networking <netdev@...r.kernel.org>, namangulati@...gle.com,
	edumazet@...gle.com, amritha.nambiar@...el.com,
	sridhar.samudrala@...el.com, sdf@...ichev.me, peter@...eblog.net,
	m2shafiei@...terloo.ca, bjorn@...osinc.com, hch@...radead.org,
	willy@...radead.org, willemdebruijn.kernel@...il.com,
	skhawaja@...gle.com, kuba@...nel.org,
	Martin Karsten <mkarsten@...terloo.ca>,
	"David S. Miller" <davem@...emloft.net>,
	Paolo Abeni <pabeni@...hat.com>, Jonathan Corbet <corbet@....net>,
	Linux Documentation <linux-doc@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux BPF <bpf@...r.kernel.org>
Subject: Re: [PATCH net-next v2 6/6] docs: networking: Describe irq suspension

On Mon, Oct 21, 2024 at 09:33:21AM -0700, Joe Damato wrote:
> On Mon, Oct 21, 2024 at 05:49:14PM +0700, Bagas Sanjaya wrote:
> > On Mon, Oct 21, 2024 at 01:53:01AM +0000, Joe Damato wrote:
> > > diff --git a/Documentation/networking/napi.rst b/Documentation/networking/napi.rst
> > > index dfa5d549be9c..3b43477a52ce 100644
> > > --- a/Documentation/networking/napi.rst
> > > +++ b/Documentation/networking/napi.rst
> > > @@ -192,6 +192,28 @@ is reused to control the delay of the timer, while
> > >  ``napi_defer_hard_irqs`` controls the number of consecutive empty polls
> > >  before NAPI gives up and goes back to using hardware IRQs.
> > >  
> > > +The above parameters can also be set on a per-NAPI basis using netlink via
> > > +netdev-genl. This can be done programmatically in a user application or by
> > > +using a script included in the kernel source tree: ``tools/net/ynl/cli.py``.
> > > +
> > > +For example, using the script:
> > > +
> > > +.. code-block:: bash
> > > +
> > > +  $ kernel-source/tools/net/ynl/cli.py \
> > > +            --spec Documentation/netlink/specs/netdev.yaml \
> > > +            --do napi-set \
> > > +            --json='{"id": 345,
> > > +                     "defer-hard-irqs": 111,
> > > +                     "gro-flush-timeout": 11111}'
> > > +
> > > +Similarly, the parameter ``irq-suspend-timeout`` can be set using netlink
> > > +via netdev-genl. There is no global sysfs parameter for this value.
> > 
> > In JSON, both gro-flush-timeout and irq-suspend-timeout parameter
> > names are written in hyphens; but the rest of the docs uses underscores
> > (that is, gro_flush_timeout and irq_suspend_timeout), right?
> 
> That's right. The YAML specification uses hyphens throughout, so we
> follow that convention there.
> 
> In the rest of the docs we use the name of the field which appears
> in the code itself, which uses underscores.

OK, thanks!

-- 
An old man doll... just what I always wanted! - Clara

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)