netdev - Re: [PATCH v1 3/9] i2c: Add Nuvoton NCT6694 I2C support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOoeyxWNed1RmZ1FDJ4sTHJ=CmhBWnGZ0wkWF_dEuQgAOqwECA@mail.gmail.com>
Date: Fri, 25 Oct 2024 15:47:05 +0800
From: 游子民 <a0282524688@...il.com>
To: Andi Shyti <andi.shyti@...nel.org>
Cc: tmyu0@...oton.com, lee@...nel.org, linus.walleij@...aro.org, brgl@...ev.pl, 
	mkl@...gutronix.de, mailhol.vincent@...adoo.fr, andrew+netdev@...n.ch, 
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, 
	wim@...ux-watchdog.org, linux@...ck-us.net, jdelvare@...e.com, 
	jic23@...nel.org, lars@...afoo.de, ukleinek@...nel.org, 
	alexandre.belloni@...tlin.com, linux-kernel@...r.kernel.org, 
	linux-gpio@...r.kernel.org, linux-i2c@...r.kernel.org, 
	linux-can@...r.kernel.org, netdev@...r.kernel.org, 
	linux-watchdog@...r.kernel.org, linux-hwmon@...r.kernel.org, 
	linux-iio@...r.kernel.org, linux-pwm@...r.kernel.org, 
	linux-rtc@...r.kernel.org
Subject: Re: [PATCH v1 3/9] i2c: Add Nuvoton NCT6694 I2C support

Sorry, resending this email in plain text format.

Dear Andi,

Thank you for your comments.

Andi Shyti <andi.shyti@...nel.org> 於 2024年10月24日 週四 下午6:41寫道：
>
> Hi Ming,
>
> ...
>
> > +static int __init nct6694_init(void)
> > +{
> > +     int err;
> > +
> > +     err = platform_driver_register(&nct6694_i2c_driver);
> > +     if (!err) {
> > +             if (err)
> > +                     platform_driver_unregister(&nct6694_i2c_driver);
> > +     }
> > +
> > +     return err;
> > +}
> > +subsys_initcall(nct6694_init);
> > +
> > +static void __exit nct6694_exit(void)
> > +{
> > +     platform_driver_unregister(&nct6694_i2c_driver);
> > +}
> > +module_exit(nct6694_exit);
>
> Have you thought about using auxiliary driver here?
> (auxiliary_bus.h)

[Ming] For platform driver registration, I'll change it to
module_platform_driver()
in the next patch.

>
> Thanks,
> Andi