netdev - RE: [Intel-wired-lan] [PATCH v2 iwl-net 4/4] ice: Add correct PHY lane assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <IA1PR11MB6219A2079049AF36228E9FC992482@IA1PR11MB6219.namprd11.prod.outlook.com>
Date: Sat, 26 Oct 2024 17:29:01 +0000
From: "Nitka, Grzegorz" <grzegorz.nitka@...el.com>
To: "Keller, Jacob E" <jacob.e.keller@...el.com>, "Kolacinski, Karol"
	<karol.kolacinski@...el.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Kubalewski, Arkadiusz"
	<arkadiusz.kubalewski@...el.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH v2 iwl-net 4/4] ice: Add correct PHY
 lane assignment



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Jacob Keller
> Sent: Thursday, October 17, 2024 1:29 AM
> To: Kolacinski, Karol <karol.kolacinski@...el.com>; intel-wired-
> lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Kubalewski, Arkadiusz
> <arkadiusz.kubalewski@...el.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>
> Subject: Re: [Intel-wired-lan] [PATCH v2 iwl-net 4/4] ice: Add correct PHY
> lane assignment
> 
> 
> 
> On 10/10/2024 7:21 AM, Karol Kolacinski wrote:
> 
> >  /**
> >   * ice_ptp_init_phy_e825 - initialize PHY parameters
> >   * @hw: pointer to the HW struct
> > @@ -2743,8 +2723,6 @@ static void ice_ptp_init_phy_e825(struct ice_hw
> *hw)
> >  	err = ice_read_phy_eth56g(hw, hw->pf_id, PHY_REG_REVISION,
> &phy_rev);
> >  	if (err || phy_rev != PHY_REVISION_ETH56G)
> >  		ptp->phy_model = ICE_PHY_UNSUP;
> > -
> > -	ptp->is_2x50g_muxed_topo = ice_is_muxed_topo(hw);
> >  }
> >
> Once we remove ptp->phy_model, this check for the PHY revision seems
> like it is meaningless?
> 
> Thanks,
> Jake

Agree, to be removed in v3.