netdev - Re: [PATCH] net: ethernet: ti: am65-cpsw: fix NULL deref check in am65_cpsw_nuss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241026124322.GC1507976@kernel.org>
Date: Sat, 26 Oct 2024 13:43:22 +0100
From: Simon Horman <horms@...nel.org>
To: Charles Han <hanchunchao@...pur.com>
Cc: rogerq@...nel.org, andrew+netdev@...n.ch, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	jpanis@...libre.com, dan.carpenter@...aro.org,
	grygorii.strashko@...com, u.kleine-koenig@...libre.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ethernet: ti: am65-cpsw: fix NULL deref check in
 am65_cpsw_nuss_probe

On Fri, Oct 25, 2024 at 05:11:39PM +0800, Charles Han wrote:
> In am65_cpsw_nuss_probe() devm_kzalloc() may return NULL but this
> returned value is not checked.
> 
> Fixes: 1af3cb3702d0 ("net: ethernet: ti: am65-cpsw: Fix hardware switch mode on suspend/resume")
> Signed-off-by: Charles Han <hanchunchao@...pur.com>

Hi Charles,

As this is a fix for Networking code it should be explicitly targeted
at the net tree like this:

	Subject: [PATCH net v2] ...

> ---
>  drivers/net/ethernet/ti/am65-cpsw-nuss.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
> index 6201a09fa5f0..7af7542093e8 100644
> --- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
> +++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
> @@ -3528,6 +3528,9 @@ static int am65_cpsw_nuss_probe(struct platform_device *pdev)
>  	common->ale_context = devm_kzalloc(dev,
>  					   ale_entries * ALE_ENTRY_WORDS * sizeof(u32),
>  					   GFP_KERNEL);
> +	if (!common->ale_context)
> +		return -ENOMEM;
> +

While I agree this error should be checked, I don't think this error
handling is correct and will lead to leaked resources. Looking
over this function I think you want (completely untested!):

	if (!common->ale_context) {
		ret = -ENOMEM;
		goto err_of_clear;
	}

>  	ret = am65_cpsw_init_cpts(common);
>  	if (ret)
>  		goto err_of_clear;

-- 
pw-bot: changes-requested