netdev - Re: [PATCH v1 6/9] hwmon: Add Nuvoton NCT6694 HWMON support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02f05807-77ae-4a3b-8170-93dd7520c719@roeck-us.net>
Date: Sat, 26 Oct 2024 07:50:14 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Ming Yu <a0282524688@...il.com>
Cc: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@...adcom.com>,
 tmyu0@...oton.com, lee@...nel.org, linus.walleij@...aro.org, brgl@...ev.pl,
 andi.shyti@...nel.org, mkl@...gutronix.de, mailhol.vincent@...adoo.fr,
 andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, wim@...ux-watchdog.org,
 jdelvare@...e.com, jic23@...nel.org, lars@...afoo.de, ukleinek@...nel.org,
 alexandre.belloni@...tlin.com, linux-kernel@...r.kernel.org,
 linux-gpio@...r.kernel.org, linux-i2c@...r.kernel.org,
 linux-can@...r.kernel.org, netdev@...r.kernel.org,
 linux-watchdog@...r.kernel.org, linux-hwmon@...r.kernel.org,
 linux-iio@...r.kernel.org, linux-pwm@...r.kernel.org,
 linux-rtc@...r.kernel.org
Subject: Re: [PATCH v1 6/9] hwmon: Add Nuvoton NCT6694 HWMON support

On 10/25/24 08:44, Guenter Roeck wrote:
> On 10/25/24 08:22, Ming Yu wrote:
> [ ... ]
> 
>>>>> +static int nct6694_fan_write(struct device *dev, u32 attr, int channel,
>>>>> +                            long val)
>>>>> +{
>>>>> +       struct nct6694_hwmon_data *data = dev_get_drvdata(dev);
>>>>> +       unsigned char enable_buf[REQUEST_HWMON_CMD0_LEN] = {0};
>>>> [Kalesh] Please try to maintain RCT order for variable declaration
>>>
>>> Ok, but that is already the case here ?
>>
>> [Ming] Is there anything that needs to be changed?
>>
> 
> I don't think so, If two lines have the same length, the order is up
> to the developer to decide.
> 
> Question though is if the buffer needs to be initialized. You should drop
> the initialization if it is not necessary. In that case the second line
> would be shorter anyway, and the order question would not arise.
> 

Actually, I just noticed that you also submitted an IIO driver which
reports the same data again. If a chip has an IIO driver, there should
be no HWMON driver since the IIO -> HWMON bridge can then be used if
necessary. So please drop this driver.

Thanks,
Guenter