netdev - RE: [PATCH v4 net-next 0/1] DualPI2 patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <AS8PR07MB79737D085046AE1820483C87A3482@AS8PR07MB7973.eurprd07.prod.outlook.com>
Date: Sat, 26 Oct 2024 16:52:03 +0000
From: "Chia-Yu Chang (Nokia)" <chia-yu.chang@...ia-bell-labs.com>
To: Jamal Hadi Salim <jhs@...atatu.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "davem@...emloft.net"
	<davem@...emloft.net>, "stephen@...workplumber.org"
	<stephen@...workplumber.org>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"dsahern@...nel.org" <dsahern@...nel.org>, "ij@...nel.org" <ij@...nel.org>,
	"ncardwell@...gle.com" <ncardwell@...gle.com>, "Koen De Schepper (Nokia)"
	<koen.de_schepper@...ia-bell-labs.com>, "g.white@...lelabs.com"
	<g.white@...lelabs.com>, "ingemar.s.johansson@...csson.com"
	<ingemar.s.johansson@...csson.com>, "mirja.kuehlewind@...csson.com"
	<mirja.kuehlewind@...csson.com>, "cheshire@...le.com" <cheshire@...le.com>,
	"rs.ietf@....at" <rs.ietf@....at>, "Jason_Livingood@...cast.com"
	<Jason_Livingood@...cast.com>, "vidhi_goel@...le.com" <vidhi_goel@...le.com>
Subject: RE: [PATCH v4 net-next 0/1] DualPI2 patch

Hi Jamal,

	Will do that, and I've noticed that your previous comment on using policy.c had not need added. So I will take action on that.
	And the CC'ed to the MAINTAINER will be done in the next version.

Brs,
Chia-Yu

-----Original Message-----
From: Jamal Hadi Salim <jhs@...atatu.com> 
Sent: Thursday, October 24, 2024 7:26 PM
To: Chia-Yu Chang (Nokia) <chia-yu.chang@...ia-bell-labs.com>
Cc: netdev@...r.kernel.org; davem@...emloft.net; stephen@...workplumber.org; edumazet@...gle.com; kuba@...nel.org; pabeni@...hat.com; dsahern@...nel.org; ij@...nel.org; ncardwell@...gle.com; Koen De Schepper (Nokia) <koen.de_schepper@...ia-bell-labs.com>; g.white@...lelabs.com; ingemar.s.johansson@...csson.com; mirja.kuehlewind@...csson.com; cheshire@...le.com; rs.ietf@....at; Jason_Livingood@...cast.com; vidhi_goel@...le.com
Subject: Re: [PATCH v4 net-next 0/1] DualPI2 patch

[You don't often get email from jhs@...atatu.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.



Hi,

On Mon, Oct 21, 2024 at 6:13 PM <chia-yu.chang@...ia-bell-labs.com> wrote:
>
> From: Chia-Yu Chang <chia-yu.chang@...ia-bell-labs.com>
>
> Hello,
>
> Specific changes in this version
> - Make succinct stateent in Kconfig for DualPI2
> - Put a blank line after each #define
> - Fix line length warning
>

Thanks for tracking the changes. Also please if you can attribute who asked for which specific change. Are you able to retrieve the previous versions changes/history and put them there? I am asking because I sent feedback to which i received no response. Then i started looking at this version and noticed you addressed some of the comments but not all. It's just more work to review since you never responded to any of the email comments i made.
Could you also please include all the stakeholders like i asked last time? This is just common practise. For example i see zero tc maintainers cc-ed yet you are adding code to that subsystem etc. It would help to read the patch submission howto.

cheers,
jamal


> Please find the updated patch for DualPI2 (IETF RFC9332 
> https://datatracker.ietf.org/doc/html/rfc9332).
>
> --
> Chia-Yu
>
> Koen De Schepper (1):
>   sched: Add dualpi2 qdisc
>
>  Documentation/netlink/specs/tc.yaml |  124 ++++
>  include/linux/netdevice.h           |    1 +
>  include/uapi/linux/pkt_sched.h      |   34 +
>  net/sched/Kconfig                   |   12 +
>  net/sched/Makefile                  |    1 +
>  net/sched/sch_dualpi2.c             | 1052 +++++++++++++++++++++++++++
>  6 files changed, 1224 insertions(+)
>  create mode 100644 net/sched/sch_dualpi2.c
>
> --
> 2.34.1
>