netdev - Re: [PATCH] libceph: Remove crush deadcode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOi1vP_rN_c6q5D25hdOHJqFFZO+AzgztH3jFnn=5Q1d_ocU7Q@mail.gmail.com>
Date: Sun, 27 Oct 2024 22:47:26 +0100
From: Ilya Dryomov <idryomov@...il.com>
To: "Dr. David Alan Gilbert" <linux@...blig.org>
Cc: xiubli@...hat.com, ceph-devel@...r.kernel.org, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] libceph: Remove crush deadcode

On Sun, Oct 27, 2024 at 10:00 PM Dr. David Alan Gilbert
<linux@...blig.org> wrote:
>
> * Ilya Dryomov (idryomov@...il.com) wrote:
> > On Sat, Oct 12, 2024 at 12:47 AM <linux@...blig.org> wrote:
> > >
> > > From: "Dr. David Alan Gilbert" <linux@...blig.org>
> > >
> > > crush_bucket_alg_name(), crush_get_bucket_item_weight(), crush_hash32(),
> > > and crush_hash32_5() were added by commit
> > > 5ecc0a0f8128 ("ceph: CRUSH mapping algorithm")
> > > in 2009 but never used.
> > >
> > > crush_hash_name() was added a little later by commit
> > > fb690390e305 ("ceph: make CRUSH hash function a bucket property")
> > > and also not used.
> > >
> > > Remove them.
> >
> > Hi David,
> >
> > The implementation of the CRUSH algorithm is shared with userspace and
> > these functions are used there (except for crush_hash32_5() perhaps).
> > They are all trivial code, so I'd prefer to keep them for convenience.
>
> OK, no problem.
> (Although perhaps an ifndef __KERNEL__ might save a few bytes?)

I'm not sure that is worth the churn.  If shaving off a teeny tiny bit
from the text section in generic distro kernels (where Ceph modules are
enabled) is really desired, I'd probably just drop these functions
(i.e. apply the patch as is).

Thanks,

                Ilya