netdev - RE: [Intel-wired-lan] [PATCH v2 iwl-net 0/4] Fix E825 initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <IA1PR11MB6219AA96E5657E994330E8DA924A2@IA1PR11MB6219.namprd11.prod.outlook.com>
Date: Mon, 28 Oct 2024 19:42:36 +0000
From: "Nitka, Grzegorz" <grzegorz.nitka@...el.com>
To: "Keller, Jacob E" <jacob.e.keller@...el.com>, "Kolacinski, Karol"
	<karol.kolacinski@...el.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH v2 iwl-net 0/4] Fix E825 initialization



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Jacob Keller
> Sent: Thursday, October 17, 2024 1:28 AM
> To: Kolacinski, Karol <karol.kolacinski@...el.com>; intel-wired-
> lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>
> Subject: Re: [Intel-wired-lan] [PATCH v2 iwl-net 0/4] Fix E825 initialization
> 
> 
> 
> On 10/10/2024 7:21 AM, Karol Kolacinski wrote:
> > E825 products have incorrect initialization procedure, which may lead to
> > initialization failures and register values.
> >
> > Fix E825 products initialization by adding correct sync delay, checking
> > the PHY revision only for current PHY and adding proper destination
> > device when reading port/quad.
> >
> > In addition, E825 uses PF ID for indexing per PF registers and as
> > a primary PHY lane number, which is incorrect.
> >
> > Karol Kolacinski (4):
> >   ice: Fix E825 initialization
> >   ice: Fix quad registers read on E825
> >   ice: Fix ETH56G FC-FEC Rx offset value
> >   ice: Add correct PHY lane assignment
> >
> 
> I applied these to net-queue, but they don't apply cleanly to next
> queue, due to conflicts with the PHY model changes and some other issues.
> 
> I also had some questions on one of the patches.
> 

Jake, please ignore my previous comments about rebase.
Like you noticed, more rework is required for net-next.
I have a patchset which addresses that.
In the meantime, let's resolve all the comments which applies to net-queue.

> Thanks,
> Jake
> 
> >  drivers/net/ethernet/intel/ice/ice_common.c   |  42 ++-
> >  drivers/net/ethernet/intel/ice/ice_common.h   |   1 +
> >  drivers/net/ethernet/intel/ice/ice_main.c     |   6 +-
> >  drivers/net/ethernet/intel/ice/ice_ptp.c      |  23 +-
> >  drivers/net/ethernet/intel/ice/ice_ptp.h      |   4 +-
> >  .../net/ethernet/intel/ice/ice_ptp_consts.h   |  77 +----
> >  drivers/net/ethernet/intel/ice/ice_ptp_hw.c   | 281 ++++++++++--------
> >  drivers/net/ethernet/intel/ice/ice_ptp_hw.h   |  40 ++-
> >  drivers/net/ethernet/intel/ice/ice_sbq_cmd.h  |   7 +-
> >  drivers/net/ethernet/intel/ice/ice_type.h     |   2 -
> >  10 files changed, 243 insertions(+), 240 deletions(-)
> >
> > V1 -> V2: Removed net-next hunks from "ice: Fix E825 initialization",
> >           whole "ice: Remove unnecessary offset calculation for PF
> >           scoped registers" patch and fixed kdoc in "ice: Fix quad
> >           registers read on E825"
> >
> > base-commit: ab8024f0207eec0f376591c958b5bd30a03ae370