netdev - Re: [PATCH 2/2] net: ncsi: restrict version sizes when hardware doesn't nul-terminate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <286f2724-2810-4a07-a82e-c6668cdbf690@lunn.ch>
Date: Mon, 28 Oct 2024 21:30:56 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Jeremy Kerr <jk@...econstruct.com.au>
Cc: Samuel Mendoza-Jonas <sam@...dozajonas.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <horms@...nel.org>, Vijay Khemka <vijaykhemka@...com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] net: ncsi: restrict version sizes when hardware
 doesn't nul-terminate

On Mon, Oct 28, 2024 at 01:06:57PM +0800, Jeremy Kerr wrote:
> When constructing a netlink NCSI channel info message, we assume that
> the hardware version field is nul-terminated, which may not be the case
> for version name strings that are exactly 12 bytes.

Is this defined by a standard? Does the standard allow non
nul-terminated strings? 

	Andrew