netdev - Re: [iwl-next v5 2/9] ice: devlink PF MSI-X max and min parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zx8qxF+4EPQZnO0k@mev-dev.igk.intel.com>
Date: Mon, 28 Oct 2024 07:10:12 +0100
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: intel-wired-lan@...ts.osuosl.org
Cc: netdev@...r.kernel.org, pawel.chmielewski@...el.com,
	sridhar.samudrala@...el.com, jacob.e.keller@...el.com,
	pio.raczynski@...il.com, konrad.knitter@...el.com,
	marcin.szycik@...el.com, wojciech.drewek@...el.com,
	nex.sw.ncis.nat.hpm.dev@...el.com, przemyslaw.kitszel@...el.com,
	jiri@...nulli.us, horms@...nel.org, David.Laight@...lab.com
Subject: Re: [iwl-next v5 2/9] ice: devlink PF MSI-X max and min parameter

On Thu, Oct 24, 2024 at 02:12:23PM +0200, Michal Swiatkowski wrote:
> Use generic devlink PF MSI-X parameter to allow user to change MSI-X
> range.
> 
> Add notes about this parameters into ice devlink documentation.
> 
> Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> ---
>  Documentation/networking/devlink/ice.rst      | 11 +++
>  .../net/ethernet/intel/ice/devlink/devlink.c  | 83 ++++++++++++++++++-
>  drivers/net/ethernet/intel/ice/ice.h          |  7 ++
>  drivers/net/ethernet/intel/ice/ice_irq.c      |  7 ++
>  4 files changed, 107 insertions(+), 1 deletion(-)
> 

[...]

> diff --git a/drivers/net/ethernet/intel/ice/ice_irq.c b/drivers/net/ethernet/intel/ice/ice_irq.c
> index ad82ff7d1995..0659b96b9b8c 100644
> --- a/drivers/net/ethernet/intel/ice/ice_irq.c
> +++ b/drivers/net/ethernet/intel/ice/ice_irq.c
> @@ -254,6 +254,13 @@ int ice_init_interrupt_scheme(struct ice_pf *pf)
>  	int total_vectors = pf->hw.func_caps.common_cap.num_msix_vectors;
>  	int vectors, max_vectors;
>  
> +	/* load default PF MSI-X range */
> +	if (!pf->msix.min)
> +		pf->msix.min = ICE_MIN_MSIX;
> +
> +	if (!pf->msix.max)
> +		pf->msix.max = total_vectors / 2;

Probably it will be better to set max to the value that PF needs after
calling ice_ena_msix_range(). I will send next version with that change,
please not pull.

Thanks,
Michal

> +
>  	vectors = ice_ena_msix_range(pf);
>  
>  	if (vectors < 0)
> -- 
> 2.42.0
>