[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8eeb1f7c-3198-45ac-be9a-c3d4e5174f1f@kernel.org>
Date: Mon, 28 Oct 2024 08:06:25 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Inochi Amaoto <inochiama@...il.com>
Cc: Chen Wang <unicorn_wang@...look.com>, Andrew Lunn
<andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Inochi Amaoto <inochiama@...look.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Jose Abreu <joabreu@...opsys.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Richard Cochran <richardcochran@...il.com>,
Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
<palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
Giuseppe Cavallaro <peppe.cavallaro@...com>, Yixun Lan <dlan@...too.org>,
Longbin Li <looong.bin@...il.com>, netdev@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v2 2/4] dt-bindings: net: Add support for Sophgo SG2044
dwmac
On 28/10/2024 00:32, Inochi Amaoto wrote:
> On Sun, Oct 27, 2024 at 09:38:00PM +0100, Krzysztof Kozlowski wrote:
>> On Fri, Oct 25, 2024 at 09:09:58AM +0800, Inochi Amaoto wrote:
>>> The GMAC IP on SG2044 is almost a standard Synopsys DesignWare MAC
>>> with some extra clock.
>>>
>>> Add necessary compatible string for this device.
>>>
>>> Signed-off-by: Inochi Amaoto <inochiama@...il.com>
>>> ---
>>
>> This should be squashed with a corrected previous patch
>
> Good, I will.
>
>> (why do you need to select snps,dwmac-5.30a?),
>
> The is because the driver use the fallback versioned compatible
> string to set up some common arguments. (This is what the patch
Nope. Driver never relies on schema doing select. That's just incorrect.
> 3 does). It is also better to have a accurate fallback compatible
> if we already know what it is.
Best regards,
Krzysztof
Powered by blists - more mailing lists