netdev - Re: [PATCH net-next 0/7] Support external snapshots on dwmac1000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241029154916.50b5f188@fedora.home>
Date: Tue, 29 Oct 2024 15:49:16 +0100
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Alexis Lothoré <alexis.lothore@...tlin.com>
Cc: Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose Abreu
 <joabreu@...opsys.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 davem@...emloft.net, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Maxime Coquelin
 <mcoquelin.stm32@...il.com>, Richard Cochran <richardcochran@...il.com>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 0/7] Support external snapshots on dwmac1000

Hi Alexis,

On Tue, 29 Oct 2024 15:45:07 +0100
Alexis Lothoré <alexis.lothore@...tlin.com> wrote:

> Hello Maxime,
> 
> On 10/29/24 12:54, Maxime Chevallier wrote:
> > Hi,
> > 
> > This series is another take on the pervious work [1] done by
> > Alexis Lothoré, that fixes the support for external snapshots
> > timestamping in GMAC3-based devices.
> >   
> 
> [...]
> 
> > [1]: https://lore.kernel.org/netdev/20230616100409.164583-1-alexis.lothore@bootlin.com/
> > 
> > Thanks Alexis for laying the groundwork for this,
> > 
> > Best regards,
> > 
> > Maxime  
> 
> Thanks for making this topic move forward. I suspect the series to be missing
> some bits: in the initial series you mention in [1], I also reworked
> stmmac_hwtstamp_set in stmmac_main.c, which is also currently assuming a GMAC4
> layout ([2]). I suspect that in your series current state, any new call to
> stmmac_hwtstamp_set will overwrite any previously configured hardware timestamping.

You are correct indeed, I missed this bit in the series. I'll update
that for v2. 

Thanks,

Maxime