netdev - Re: [PATCH] qed/qed_sriov: avoid null-ptr-deref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <61611603-4dd0-4d75-a0b7-d21299d4610c@intel.com>
Date: Tue, 29 Oct 2024 16:15:45 +0100
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Chen Ridong <chenridong@...weicloud.com>
CC: <manishc@...vell.com>, <andrew+netdev@...n.ch>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<netdev@...r.kernel.org>, <wangweiyang2@...wei.com>
Subject: Re: [PATCH] qed/qed_sriov: avoid null-ptr-deref

From: Chen Ridong <chenridong@...weicloud.com>
Date: Tue, 29 Oct 2024 09:42:11 +0800

> 
> 
> On 2024/10/25 23:28, Alexander Lobakin wrote:
>> From: Chen Ridong <chenridong@...weicloud.com>
>> Date: Fri, 25 Oct 2024 09:31:35 +0000
>>
>>> [PATCH] qed/qed_sriov: avoid null-ptr-deref
>>
>> Use the correct tree prefix, [PATCH net] in your case.
>>
> 
> Thanks, will update
> 
>>> From: Chen Ridong <chenridong@...wei.com>
>>
>> Why do you commit from @huawei.com, but send from @huaweicloud.com?
>>
> The @huawei.com is the email I am actually using. But if I use it to
> send email, my patches may not appear in maintainers's inbox list. This
> won't be happened when I use 'huaweicloud.com' to send emails. So I am
> using 'huaweicloud.com' to communicate with community. However, I would
> like to maintain the same author identity.
> 
>>>
>>> The qed_iov_get_public_vf_info may return NULL, which may lead to
>>> null-ptr-deref. To avoid possible null-ptr-deref, check vf_info
>>
>> Do you have a repro for this or it's purely hypothetical?
>>
> 
> I read the code and found that calling qed_iov_get_public_vf_info
> without checking whether the 'vfid' is valid  may result in a null
> pointer, which may lead to a null pointer dereference.

If you want to submit a fix, you need to have a step-by-step manual how
to reproduce the bug you're fixing.

> 
>>> before accessing its member.
>>>
>>
>> Here you should have a "Fixes:" tag if you believe this is a fix.

Thanks,
Olek