netdev - Re: [PATCH net-next v6 1/1] binder: report txn errors via generic netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANBPYPiYAVDMeBUNRm8_wJojropMSL00UkGGV1ar+E3Y1STYfA@mail.gmail.com>
Date: Tue, 29 Oct 2024 08:52:59 -0700
From: Li Li <dualli@...omium.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: dualli@...gle.com, corbet@....net, davem@...emloft.net, 
	edumazet@...gle.com, pabeni@...hat.com, donald.hunter@...il.com, 
	gregkh@...uxfoundation.org, arve@...roid.com, tkjos@...roid.com, 
	maco@...roid.com, joel@...lfernandes.org, brauner@...nel.org, 
	cmllamas@...gle.com, surenb@...gle.com, arnd@...db.de, masahiroy@...nel.org, 
	bagasdotme@...il.com, horms@...nel.org, linux-kernel@...r.kernel.org, 
	linux-doc@...r.kernel.org, netdev@...r.kernel.org, hridya@...gle.com, 
	smoreland@...gle.com, kernel-team@...roid.com
Subject: Re: [PATCH net-next v6 1/1] binder: report txn errors via generic netlink

On Tue, Oct 29, 2024 at 7:14 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Mon, 28 Oct 2024 03:19:51 -0700 Li Li wrote:
> > +                     report.err = BR_ONEWAY_SPAM_SUSPECT;
> > +                     report.from_pid = proc->pid;
> > +                     report.from_tid = thread->pid;
> > +                     report.to_pid = target_proc ? target_proc->pid : 0;
> > +                     report.to_tid = target_thread ? target_thread->pid : 0;
> > +                     report.reply = reply;
> > +                     report.flags = tr->flags;
> > +                     report.code = tr->code;
> > +                     report.data_size = tr->data_size;
> > +                     binder_genl_send_report(context, &report, sizeof(report));
>
> Could you break this struct apart into individual attributes?
> Carrying binary structs in netlink has been done historically
> but we moved away from it. It undermines the ability to extend
> the output and do automatic error checking.

Sure!

>
> BTW if you would like to keep using the uapi/linux/android directory
> feel free to add this as the first patch of the series:
> https://github.com/kuba-moo/linux/commit/73fde49060cd89714029ccee5d37dcc37b8291f6

Awesome. Thank you for the patch!