[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241029113955.145d2a2f@kernel.org>
Date: Tue, 29 Oct 2024 11:39:55 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc: "Gustavo A. R. Silva" <gustavoars@...nel.org>, Michael Chan
<michael.chan@...adcom.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David S.
Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
Abeni <pabeni@...hat.com>, Potnuri Bharat Teja <bharat@...lsio.com>,
Christian Benvenuti <benve@...co.com>, Satish Kharat <satishkh@...co.com>,
Manish Chopra <manishc@...vell.com>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH 2/2][next] net: ethtool: Avoid thousands of
-Wflex-array-member-not-at-end warnings
On Tue, 29 Oct 2024 12:18:56 -0600 Gustavo A. R. Silva wrote:
> >> I don't think you want to change this. `lsettings` is based on `ksettings`. So,
> >> `ksettings` should go first. The same scenario for the one below.
> >
> > In which case you need to move the init out of line.
>
> So, the same applies to the case below?
>
> const struct ethtool_link_settings_hdr *base = &lk_ksettings->base;
> struct bnxt *bp = netdev_priv(dev);
> struct bnxt_link_info *link_info = &bp->link_info;
Do you mean the bp and bp->link_info lines?
You're not touching them, so leave them be.
> Is this going to be a priority for any other netdev patches in the future?
It's been the preferred formatting for a decade or more.
Which is why the net/ethtool/ code you're touching follows
this convention. We're less strict about driver code.
Powered by blists - more mailing lists