netdev - Re: [PATCH net-next v2 0/8] net: Shift responsibility for FDB notifications to drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241029121807.1a00ae7d@kernel.org>
Date: Tue, 29 Oct 2024 12:18:07 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Petr Machata <petrm@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 <netdev@...r.kernel.org>, Ido Schimmel <idosch@...dia.com>, "Amit Cohen"
 <amcohen@...dia.com>, Vladimir Oltean <vladimir.oltean@....com>, "Andy
 Roulin" <aroulin@...dia.com>, <mlxsw@...dia.com>
Subject: Re: [PATCH net-next v2 0/8] net: Shift responsibility for FDB
 notifications to drivers

On Thu, 24 Oct 2024 18:57:35 +0200 Petr Machata wrote:
> Besides this approach, we considered just passing a boolean back from the
> driver, which would indicate whether the notification was done. But the
> approach presented here seems cleaner.

Oops, I missed the v2, same question:

  What about adding a bit to the ops struct to indicate that 
  the driver will generate the notification? Seems smaller in 
  terms of LoC and shifts the responsibility of doing extra
  work towards more complex users.

https://lore.kernel.org/all/20241029121619.1a710601@kernel.org/