netdev - Re: [PATCH] Add LAN78XX OTP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <75302a2c-f13e-4a5c-ac46-2a8da98a7b7c@lunn.ch>
Date: Tue, 29 Oct 2024 22:14:12 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Ronnie.Kunin@...rochip.com, Fabi.Benschuh@....de,
	Woojung.Huh@...rochip.com, UNGLinuxDriver@...rochip.com,
	andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	pabeni@...hat.com, netdev@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH] Add LAN78XX OTP_ACCESS flag support

On Tue, Oct 29, 2024 at 10:43:13AM -0700, Jakub Kicinski wrote:
> On Mon, 28 Oct 2024 20:19:04 +0100 Andrew Lunn wrote:
> > > This is pretty much the same implementation that is already in place
> > > for the Linux driver of the LAN743x PCIe device.  
> > 
> > That is good, it gives some degree of consistency. But i wounder if we
> > should go further. I doubt these are the only two devices which
> > support both EEPROM and OTP. It would be nicer to extend ethtool:
> > 
> >        ethtool -e|--eeprom-dump devname [raw on|off] [offset N] [length N] [otp] [eeprom]
> 
> After a cursory look at the conversation I wonder if it wouldn't 
> be easier to register devlink regions for eeprom and otp?

Hi Jakub

devlink regions don't allow write. ethtool does.

	Andrew