netdev - Re: [RFC PATCH 2/2] net: selpcimac: Add driver for SEL PCIe network adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PH0PR22MB3809834A1A62CB9B635733E2E54B2@PH0PR22MB3809.namprd22.prod.outlook.com>
Date: Tue, 29 Oct 2024 23:01:21 +0000
From: Robert Joslyn <Robert_Joslyn@...inc.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC: "lee@...nel.org" <lee@...nel.org>
Subject: Re: [RFC PATCH 2/2] net: selpcimac: Add driver for SEL PCIe network
 adapter

>________________________________________
>From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
>Sent: Tuesday, October 29, 2024 10:19 AM
>To: Robert Joslyn; linux-kernel@...r.kernel.org; netdev@...r.kernel.org
>Cc: lee@...nel.org
>Subject: Re: [RFC PATCH 2/2] net: selpcimac: Add driver for SEL PCIe network adapter
>
>[Caution - External]
>
>Le 28/10/2024 à 23:35, Robert Joslyn a écrit :
>> Add support for SEL FPGA based network adapters. The network device is
>> implemented as an FPGA IP core and enumerated by the selpvmf driver.
>> This is used on multiple devices, including:
>>   - SEL-3350 mainboard
>>   - SEL-3390E4 card
>>   - SEL-3390T card
>>
>> Signed-off-by: Robert Joslyn <robert_joslyn@...inc.com>
>> ---
>
>Hi,
>
>a few nitpicks below, should it help.
>
...
>> +
>> +     WARN_ON_ONCE((ring->dma % SEL_DATA_ALIGN) != 0);
>> +
>> +     memset(ring->desc, 0, ring->size);
>
>If I recollect correctly, dma_alloc_coherent() returns some zeroed memory.

You're right, I walked through that code and it does a memset to zero internally.

>
>CJ
>

Thanks for taking a look, I'll work these suggestions into the next patch set.

Robert