netdev - Re: [PATCH for-next 7/7] selftests/net: Fix ./ns-XXXXXX not cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241029164306.6122b372@kernel.org>
Date: Tue, 29 Oct 2024 16:43:06 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Li Zhijian <lizhijian@...itsu.com>
Cc: linux-kselftest@...r.kernel.org, shuah@...nel.org,
 linux-kernel@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 netdev@...r.kernel.org
Subject: Re: [PATCH for-next 7/7] selftests/net: Fix ./ns-XXXXXX not cleanup

On Fri, 25 Oct 2024 09:40:10 +0800 Li Zhijian wrote:
> ```
> readonly STATS="$(mktemp -p /tmp ns-XXXXXX)"
> readonly BASE=`basename $STATS`
> ```
> It could be a mistake to write to $BASE rather than $STATS, where $STATS
> is used to save the NSTAT_HISTORY and it will be cleaned up before exit.

Agreed, although since we've been creating the wrong file this whole
time and everything worked -- should we just just delete those two
lines completely?

Similarly to patch 6 - please repost as a standalone patch so that our
CI will test it. If you only CC a mailing list on subset of patches
they are likely to be ignored by automation..
-- 
pw-bot: cr