netdev - Re: [PATCH net-next v5 03/12] selftests: ncdevmem: Unify error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241029170129.75e29323@kernel.org>
Date: Tue, 29 Oct 2024 17:01:29 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Stanislav Fomichev <sdf@...ichev.me>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org, andrew+netdev@...n.ch, shuah@...nel.org,
 almasrymina@...gle.com, willemb@...gle.com, petrm@...dia.com
Subject: Re: [PATCH net-next v5 03/12] selftests: ncdevmem: Unify error
 handling

On Wed, 23 Oct 2024 08:43:53 -0700 Stanislav Fomichev wrote:
>  	ret = inet_pton(server_sin.sin_family, server_ip, &server_sin.sin_addr);
> -	if (socket < 0)
> -		error(79, 0, "%s: [FAIL, create socket]\n", TEST_PREFIX);
> +	if (ret < 0)
> +		error(1, pton, "%s: [FAIL, create socket]\n", TEST_PREFIX);

Looks like sched_ext broke our build_tools check, I think I pushed a
fix, but I also see here:

ncdevmem.c: In function ‘do_server’:
ncdevmem.c:343:26: error: ‘pton’ undeclared (first use in this function)
  343 |                 error(1, pton, "%s: [FAIL, create socket]\n", TEST_PREFIX);
      |                          ^~~~
-- 
pw-bot: cr