netdev - Re: [PATCH nf] netfilter: nf_reject_ipv6: fix potential crash in nf_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZyIdZlw8Tu2nxJ6l@calendula>
Date: Wed, 30 Oct 2024 12:49:58 +0100
From: Pablo Neira Ayuso <pablo@...filter.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Jozsef Kadlecsik <kadlec@...filter.org>, netdev@...r.kernel.org,
	netfilter-devel@...r.kernel.org, coreteam@...filter.org,
	eric.dumazet@...il.com, syzbot <syzkaller@...glegroups.com>
Subject: Re: [PATCH nf] netfilter: nf_reject_ipv6: fix potential crash in
 nf_send_reset6()

On Fri, Oct 25, 2024 at 08:02:29AM +0000, Eric Dumazet wrote:
> I got a syzbot report without a repro [1] crashing in nf_send_reset6()
> 
> I think the issue is that dev->hard_header_len is zero, and we attempt
> later to push an Ethernet header.
> 
> Use LL_MAX_HEADER, as other functions in net/ipv6/netfilter/nf_reject_ipv6.c.

Thanks, I will include this in the next PR with netfilter fixes.